From: Andrew Cagney <ac131313@ges.redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/5.2/commit] Zap __func__
Date: Mon, 15 Jul 2002 13:09:00 -0000 [thread overview]
Message-ID: <3D332BFF.6030009@ges.redhat.com> (raw)
In-Reply-To: <20020715175206.GA19809@nevyn.them.org>
> On Mon, Jul 15, 2002 at 12:42:49PM -0400, Andrew Cagney wrote:
>
>> Just FYI,
>>
>> I've committed this to the 5.2 branch - zap more __func__s. It's brutal
>> but it works :-)
>>
>> enjoy,
>> Andrew
>
>
>> 2002-07-15 Andrew Cagney <ac131313@redhat.com>
>>
>> * dwarf2cfi.c: Replace __func__ with "?func?".
>
>
> Er, hunh?
>
> First of all, is there any reason that __FUNCTION__ is not adequately
> portable? I think it is. Second of all, if you're going to remove
> __func__ you could at least replace it with the name of the function.
Remember this is a branch and those ``__func__''s were only printed when
there was an internal_error() - I don't think anyone is going to notice
:-). The correct clean fix was committed to the mainline a few hours
earlier (I looked at back patching it but noticed too many differences).
As for __FUNCTION__, that isn''t part of ISO C 90.
enjoy,
Andrew
next prev parent reply other threads:[~2002-07-15 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-15 9:50 Andrew Cagney
2002-07-15 11:18 ` Daniel Jacobowitz
2002-07-15 13:09 ` Andrew Cagney [this message]
2002-07-15 13:42 ` Daniel Jacobowitz
2002-07-15 15:00 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D332BFF.6030009@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox