From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16898-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 18178 invoked by alias); 14 Jul 2002 16:31:45 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18124 invoked from network); 14 Jul 2002 16:31:37 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.240.27)
  by sources.redhat.com with SMTP; 14 Jul 2002 16:31:37 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 198BE3DB6; Sun, 14 Jul 2002 12:31:32 -0400 (EDT)
Message-ID: <3D31A763.7020904@ges.redhat.com>
Date: Sun, 14 Jul 2002 09:51:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Johan Rydberg <jrydberg@rtmk.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] remote_rcmd
References: <20020627035114.M1899@cockmaster.bredbandsbolaget.se>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-07/txt/msg00301.txt.bz2

> Hi,
> 
> This small patch adds support for receving more that ~200 bytes
> of output from the "qRcmd" request (ie the monitor command).
> 
> I have no idea if this will break any stubs, but hopefully not.
> I don't know how often stubs implement the qRcmd request.
> 
> 2002-06-27  Johan Rydberg  <jrydberg@rtmk.org>
> 
>         * remote.c (remote_rcmd): Continue reading output from
>         stub until receiving OK.

If I understand this patch correctly, it is changing things so that it 
allows:

	-> rCmd <command>
	<- <HEX-OUTPUT>
	<- <HEX-OUTPUT>
	<- OK

This is wrong.  The target should send:

	-> rCmd <command>
	<- O <HEX-OUTPUT>
	<- O <HEX-OUTPUT>
	<- OK

when transfering a longer buffer.

Andrew

> Index: remote.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote.c,v
> retrieving revision 1.87
> diff -u -u -r1.87 remote.c
> --- remote.c	15 Jun 2002 22:05:32 -0000	1.87
> +++ remote.c	27 Jun 2002 01:42:02 -0000
> @@ -5210,7 +5210,6 @@
>  	  char c = (fromhex (p[0]) << 4) + fromhex (p[1]);
>  	  fputc_unfiltered (c, outbuf);
>  	}
> -      break;
>      }
>  }
>