From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16895-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 25026 invoked by alias); 14 Jul 2002 15:04:36 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25019 invoked from network); 14 Jul 2002 15:04:35 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.240.27)
  by sources.redhat.com with SMTP; 14 Jul 2002 15:04:35 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 865E33DB6; Sun, 14 Jul 2002 11:03:48 -0400 (EDT)
Message-ID: <3D3192D4.1060106@ges.redhat.com>
Date: Sun, 14 Jul 2002 08:13:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Aidan Skinner <aidan@velvet.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] ada-tasks.c: k&r defn cleanup
References: <20020714131348.L21268@velvet.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-07/txt/msg00298.txt.bz2

> Ok, I'm asking for approval for this patch because I'm a wuss and I'd
> like to make sure that what I'm doing for this is correct. This patch
> changes all the k&r function definitions in ada-tasks.c to use the
> prototyped form, and makes grep ^func work.

Yes!

> If this is ok, I'll commit this and then make similar changes to
> ada-lang.c, ada-typeprint.c and ada-valprint.c and commit them as
> obvious over the next few days.

Just a style tweak to get the hang of ...

> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/gdb/ChangeLog,v
> retrieving revision 1.2905
> diff -u -r1.2905 ChangeLog
> --- ChangeLog   13 Jul 2002 12:25:16 -0000      1.2905
> +++ ChangeLog   14 Jul 2002 12:12:33 -0000
> @@ -1,3 +1,8 @@
> +2002-07-14  Aidan Skinner <aidan@velvet.net>
> +
> +       * ada-tasks.c: change k&r style function definitions to prototyped
> +       form.

Edit-case ``change''.  It should be a sentence, leading capital, 
trailing period.

enjoy,
Andrew