From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15884 invoked by alias); 13 Jul 2002 23:53:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15865 invoked from network); 13 Jul 2002 23:53:18 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 13 Jul 2002 23:53:18 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 168003CA9; Sat, 13 Jul 2002 19:53:04 -0400 (EDT) Message-ID: <3D30BD5F.6050205@ges.redhat.com> Date: Sat, 13 Jul 2002 17:25:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com, nick@duffek.com Subject: Re: [PATCH RFC] AIX thread support References: <1020712192417.ZM7533@localhost.localdomain> <3D2F5F6F.9080308@ges.redhat.com> <1020713011530.ZM10495@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00294.txt.bz2 > [...] > >> A quick glance suggests a review is needed. For instance, from a >> coding (not thread -> MichaelS) viewpoint ``#define DEBUG 0'' should be >> handled at run-time and should be written to ``gdb_stdlog''. If >> anything, perhaphs like for ada, this file could be initially commited, >> but not actually included/enabled. That should at least make the review >> process easier. > > > As suggested, I've commited aix-thread.c to make the review process > easier. > > Keep in mind that aix-thread.c will only be used for native AIX > builds. As such, I think the criteria for including/enabling this > code should be much lower than that for core code or even target > specific code. No. Past history teaches us that once code is in and enabled it is very unlikely to be cleaned up or fixed. Instead the problematic aspects tend to be copied leading to a gradual spread. #define DEBUG is, itself, an example of this problem. The idea was likely (and unfortunatly) picked up from one of the other older modules that still uses that and similar techniques. Andrew