From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28530 invoked by alias); 12 Jul 2002 23:22:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28523 invoked from network); 12 Jul 2002 23:22:47 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 12 Jul 2002 23:22:47 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 732C43D53; Fri, 12 Jul 2002 19:22:43 -0400 (EDT) Message-ID: <3D2F64C3.7020908@ges.redhat.com> Date: Fri, 12 Jul 2002 16:24:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jim Blandy , Fernando Nasser Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: handle GDB prompt appearing in command output References: <20020204035847.9B3805E9DE@zwingli.cygnus.com> Content-Type: multipart/mixed; boundary="------------070209020702090805060304" X-SW-Source: 2002-07/txt/msg00288.txt.bz2 This is a multi-part message in MIME format. --------------070209020702090805060304 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1420 > Sun Feb 3 19:52:31 2002 Jim Blandy >> >> * gdb.base/default.exp: Distinguish the GDB prompt as it appears >> in "info set" and "show" output from the true prompt. >> >> Index: gdb/testsuite/gdb.base/default.exp >> =================================================================== >> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/default.exp,v >> retrieving revision 1.39.56.2 >> diff -c -r1.39.56.2 default.exp >> *** gdb/testsuite/gdb.base/default.exp 2001/12/20 22:34:38 1.39.56.2 >> --- gdb/testsuite/gdb.base/default.exp 2002/02/04 03:51:57 >> *************** >> *** 330,336 **** >> # FIXME -- needs to match the entire output >> # FIXME -- on native solaris 2.8, this test fails due to this line: >> # prompt: Gdb's prompt is "(gdb) ".^M >> ! gdb_test "info set" "confirm: Whether to confirm potentially dangerous operations is o\[a-z\]*..*\[\r\n\]+history filename: The filename in which to record the command history is .*\[\r\n\]+listsize: Number of source lines gdb will list by default is 10.*" "info set" >> gdb_test "info symbol" "Argument required .address.." >> #test info source >> gdb_test "info source" "No current source file..*" "info source" >> Jim, As a side effect, this patch no longer checks that the order is correct. Is this intentional? gdb_expect_list might prove a better choice since it still enforces the order. Andrew --------------070209020702090805060304 Content-Type: message/rfc822; name="mailbox-message://ac131313@movemail/fsf/gdb/patches/sep#3188216" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mailbox-message://ac131313@movemail/fsf/gdb/patches/sep#3188216" Content-length: 7405 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: ac131313@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 619CC3DC9 for ; Thu, 20 Jun 2002 14:36:03 -0400 (EDT) Received: from pop.sfbay.redhat.com by localhost with IMAP (fetchmail-5.9.11) for ac131313@localhost (single-drop); Thu, 20 Jun 2002 14:36:03 -0400 (EDT) Received: from ges.redhat.com (cygnus-mx.sfbay.redhat.com [172.16.27.16]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA11522 for ; Thu, 20 Jun 2002 11:24:31 -0700 (PDT) Received: from sources.redhat.com (sources.redhat.com [209.249.29.67]) by ges.redhat.com (8.11.6/8.11.6) with SMTP id g5KAXn822936 for ; Thu, 20 Jun 2002 03:33:49 -0700 Received: (qmail 11362 invoked by alias); 20 Jun 2002 18:23:26 -0000 Received: (qmail 11282 invoked from network); 20 Jun 2002 18:23:24 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 20 Jun 2002 18:23:24 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 00EEC5EA11; Thu, 20 Jun 2002 13:23:22 -0500 (EST) Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com To: gdb-patches@sources.redhat.com Subject: Re: RFA: handle GDB prompt appearing in command output References: <20020204035847.9B3805E9DE@zwingli.cygnus.com> From: Jim Blandy Date: 20 Jun 2002 13:23:22 -0500 In-Reply-To: <20020204035847.9B3805E9DE@zwingli.cygnus.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-length: 5164 Ping to testsuite maintainer: this patch needs review. Jim Blandy writes: > Sun Feb 3 19:52:31 2002 Jim Blandy > > * gdb.base/default.exp: Distinguish the GDB prompt as it appears > in "info set" and "show" output from the true prompt. > > Index: gdb/testsuite/gdb.base/default.exp > =================================================================== > RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.base/default.exp,v > retrieving revision 1.39.56.2 > diff -c -r1.39.56.2 default.exp > *** gdb/testsuite/gdb.base/default.exp 2001/12/20 22:34:38 1.39.56.2 > --- gdb/testsuite/gdb.base/default.exp 2002/02/04 03:51:57 > *************** > *** 330,336 **** > # FIXME -- needs to match the entire output > # FIXME -- on native solaris 2.8, this test fails due to this line: > # prompt: Gdb's prompt is "(gdb) ".^M > ! gdb_test "info set" "confirm: Whether to confirm potentially dangerous operations is o\[a-z\]*..*\[\r\n\]+history filename: The filename in which to record the command history is .*\[\r\n\]+listsize: Number of source lines gdb will list by default is 10.*" "info set" > gdb_test "info symbol" "Argument required .address.." > #test info source > gdb_test "info source" "No current source file..*" "info source" > --- 330,368 ---- > # FIXME -- needs to match the entire output > # FIXME -- on native solaris 2.8, this test fails due to this line: > # prompt: Gdb's prompt is "(gdb) ".^M > ! send_gdb "info set\n" > ! set seen_confirm 0 > ! set seen_history 0 > ! set seen_prompt 0 > ! set seen_listsize 0 > ! gdb_expect { > ! -re ".*confirm: Whether to confirm potentially dangerous operations is" { > ! set seen_confirm 1 > ! exp_continue > ! } > ! -re ".*history filename: The filename in which to record the command history is" { > ! set seen_history 1 > ! exp_continue > ! } > ! -re ".*listsize: Number of source lines gdb will list by default is 10" { > ! set seen_listsize 1 > ! exp_continue > ! } > ! -re ".*prompt: Gdb's prompt is \"${gdb_prompt}" { > ! set seen_prompt 1 > ! exp_continue > ! } > ! -re ".*\[\r\n\]+${gdb_prompt} $" { > ! } > ! timeout { > ! fail "info set (timeout)" > ! } > ! } > ! if {$seen_confirm && $seen_history && $seen_prompt && $seen_listsize} { > ! pass "info set" > ! } else { > ! fail "info set" > ! } > gdb_test "info symbol" "Argument required .address.." > #test info source > gdb_test "info source" "No current source file..*" "info source" > *************** > *** 663,669 **** > # This is only supported on targets which use exec.o. > gdb_test "show write" "Writing into executable and core files is o.*" "show write" > #test show > ! gdb_test "show" "confirm: *Whether to confirm potentially dangerous operations is on..*\[\r\n\]+history filename: *The filename in which to record the command history is .*\[\r\n\]+history save: *Saving of the history record on exit is on..*\[\r\n\]+history size: *The size of the command history is.*\[\r\n\]+listsize: *Number of source lines gdb will list by default is 10.*\[\r\n\]+print elements: *Limit on string chars or array elements to print is 200..*" "show" > #test stepi "si" abbreviation > setup_xfail "a29k-*-udi" > gdb_test "si" "The program is not being run." "stepi \"si\" abbreviation" > --- 695,749 ---- > # This is only supported on targets which use exec.o. > gdb_test "show write" "Writing into executable and core files is o.*" "show write" > #test show > ! send_gdb "show\n" > ! set seen_confirm 0 > ! set seen_history_filename 0 > ! set seen_history_save 0 > ! set seen_history_size 0 > ! set seen_listsize 0 > ! set seen_print_elements 0 > ! set seen_prompt 0 > ! gdb_expect { > ! -re ".*confirm: *Whether to confirm potentially dangerous operations is" { > ! set seen_confirm 1 > ! exp_continue > ! } > ! -re ".*history filename: *The filename in which to record the command" { > ! set seen_history_filename 1 > ! exp_continue > ! } > ! -re ".*history save: *Saving of the history record on exit is" { > ! set seen_history_save 1 > ! exp_continue > ! } > ! -re ".*history size: *The size of the command history is" { > ! set seen_history_size 1 > ! exp_continue > ! } > ! -re ".*listsize: *Number of source lines gdb will list by default is" { > ! set seen_listsize 1 > ! exp_continue > ! } > ! -re ".*print elements: *Limit on string chars or array elements to" { > ! set seen_print_elements 1 > ! exp_continue > ! } > ! -re "prompt: Gdb's prompt is \"${gdb_prompt}" { > ! set seen_prompt 1 > ! exp_continue > ! } > ! -re ".*\[\r\n\]+${gdb_prompt} $" { > ! } > ! timeout { > ! fail "show (timeout)" > ! } > ! } > ! if {$seen_confirm && $seen_history_filename && $seen_history_save && $seen_history_size && $seen_listsize && $seen_print_elements && $seen_prompt} { > ! pass "show" > ! } else { > ! fail "show" > ! } > ! > #test stepi "si" abbreviation > setup_xfail "a29k-*-udi" > gdb_test "si" "The program is not being run." "stepi \"si\" abbreviation" --------------070209020702090805060304--