Re: [PATCH RFC] AIX thread support

Andrew Cagney
2002-07-13T23:53:20Z

> [...]
>
>> A quick glance suggests a review is needed. For instance, from a
>> coding (not thread -> MichaelS) viewpoint ``#define DEBUG 0'' should be
>> handled at run-time and should be written to ``gdb_stdlog''. If
>> anything, perhaphs like for ada, this file could be initially commited,
>> but not actually included/enabled. That should at least make the review
>> process easier.
>
>
> As suggested, I've commited aix-thread.c to make the review process
> easier.
>
> Keep in mind that aix-thread.c will only be used for native AIX
> builds. As such, I think the criteria for including/enabling this
> code should be much lower than that for core code or even target
> specific code.

No.

Past history teaches us that once code is in and enabled it is very
unlikely to be cleaned up or fixed. Instead the problematic aspects
tend to be copied leading to a gradual spread.

#define DEBUG is, itself, an example of this problem. The idea was
likely (and unfortunatly) picked up from one of the other older modules
that still uses that and similar techniques.

Andrew