Re: [PATCH RFC] AIX thread support

Kevin Buettner
2002-07-13T01:15:49Z

On Jul 12, 6:59pm, Andrew Cagney wrote:

> > From Nicholas Duffek (with minor changes by Martin Hunt,
> > Louis Hamilton, and Kevin Buettner):
> > * aix-thread.c: New file.
> > * Makefile.in (ALLDEPFILES): Add aix-thread.c.
> > (aix-thread.o): New rule.
> > * configure.host (gdb_host): Set to aix432 on AIX 4.3.2+.
> > * config/powerpc/aix432.mh: New file.
>
[...]
> A quick glance suggests a review is needed. For instance, from a
> coding (not thread -> MichaelS) viewpoint ``#define DEBUG 0'' should be
> handled at run-time and should be written to ``gdb_stdlog''. If
> anything, perhaphs like for ada, this file could be initially commited,
> but not actually included/enabled. That should at least make the review
> process easier.

As suggested, I've commited aix-thread.c to make the review process
easier.

Keep in mind that aix-thread.c will only be used for native AIX
builds. As such, I think the criteria for including/enabling this
code should be much lower than that for core code or even target
specific code.

I do agree that there are a number of things in this file which should
be cleaned up over time. However, for the initial review, I suggest
that we focus on issues which might make overall GDB maintenance or
future GDB development more difficult. Only issues which meet these
criteria should prevent aix-thread.c from being accepted.

I certainly have no objection, however, to reviewers identifying other
cleanups that should occur over time. I think your comment regarding
``#define DEBUG 0'' is a good example of this.

Kevin