From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24557 invoked by alias); 10 Jul 2002 14:19:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24513 invoked from network); 10 Jul 2002 14:19:56 -0000 Received: from unknown (HELO tetsuo.nj.caldera.com) (63.124.204.226) by sources.redhat.com with SMTP; 10 Jul 2002 14:19:56 -0000 Received: from caldera.com (localhost.localdomain [127.0.0.1]) by tetsuo.nj.caldera.com (8.11.6/8.11.6) with ESMTP id g6AEW8403620; Wed, 10 Jul 2002 10:32:08 -0400 Message-ID: <3D2C4567.3AD10A8B@caldera.com> Date: Wed, 10 Jul 2002 07:25:00 -0000 From: Petr Sorfa Organization: Caldera X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: "gdb-patches@sources.redhat.com" Subject: Re: [PATCH] DW_AT_calling_convention support References: <3D2B5385.997D474D@caldera.com> <20020709211520.GA21948@nevyn.them.org> <3D2B576E.85B28074@caldera.com> <20020709215812.GA966@nevyn.them.org> <3D2C3C5F.A74215A4@caldera.com> <20020710140354.GA25081@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00179.txt.bz2 Hi Daniel, Great, however I do suggest get_main_symbol() for greater flexibility. I've moved the code to deal with DW_AT_calling_convention into dwarf2read.c's new_symbol() function (as opposed to detecting it while reading a type). Let me know what you think and I'll have a patch ready soon. Petr > On Wed, Jul 10, 2002 at 09:53:35AM -0400, Petr Sorfa wrote: > > Hi Daniel, > > > > > I'd rather save a pointer the symbol for the main function, or > > > something along those lines - do you think that's workable? > > Sounds good. Note that I'm making the assumption that the symbol is > > associated with a type that is only associated with that symbol (iff). > > > > I think it should be API driven, like set_main_symbol () and > > get_main_symbol () and situated in symtab.c alonside set_main_name() and > > main_name(). > > Yep, that's about what I had in mind. How about: > > set_main_name () > set_main_symbol () > is_main_symbol () > - if a main symbol is set, check if it is the same symbol > - otherwise, check if it has the same name as passed to > set_main_name > > (with appropriate care for when we change object files.... to one > without a DWARF-2 main symbol, even...) > > -- > Daniel Jacobowitz Carnegie Mellon University > MontaVista Software Debian GNU/Linux Developer