From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16731-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 22267 invoked by alias); 9 Jul 2002 03:15:58 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 22213 invoked from network); 9 Jul 2002 03:15:55 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.240.27)
  by sources.redhat.com with SMTP; 9 Jul 2002 03:15:55 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 203973CC5; Mon,  8 Jul 2002 23:15:41 -0400 (EDT)
Message-ID: <3D2A555C.9060500@ges.redhat.com>
Date: Mon, 08 Jul 2002 20:20:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Daniel Berlin <dberlin@dberlin.org>, jimb@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: dwarf2expr.[ch]
References: <Pine.LNX.4.44.0207081941190.31676-100000@dberlin.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-07/txt/msg00134.txt.bz2

Daniel,

Just a reminder.  As a GNU developer, you're expected to submit patches 
that meet the GNU coding standard.  This is important as it saves on 
significiant run-around time spent by both yourself and the reviewer.

I guess you ment, work-in-progress.

A quick glance at this patch reveals:

> Index: dwarf2expr.c
> ===================================================================
> RCS file: dwarf2expr.c
> diff -N dwarf2expr.c
> *** /dev/null	1 Jan 1970 00:00:00 -0000
> --- dwarf2expr.c	8 Jul 2002 23:41:18 -0000
> ***************
> *** 0 ****
> --- 1,479 ----

No copyright notice.

> + 
> + #include "defs.h"
> + #include "symtab.h"
> + #include "gdbtypes.h"
> + #include "elf/dwarf2.h"
> + #include "dwarf2expr.h"

Incorrectly indented function prototype (one of many).  Should be ISO C.

> + struct dwarf_expr_context * new_dwarf_expr_context()
> + {
> +   struct dwarf_expr_context *retval;
> +   retval = xcalloc (1, sizeof (struct dwarf_expr_context));
> +   return retval;
> + }

enjoy,
Andrew