From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4468 invoked by alias); 9 Jul 2002 02:19:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4456 invoked from network); 9 Jul 2002 02:19:02 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 9 Jul 2002 02:19:02 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E14EF3CC5; Mon, 8 Jul 2002 22:18:57 -0400 (EDT) Message-ID: <3D2A4811.9000908@ges.redhat.com> Date: Mon, 08 Jul 2002 20:06:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: initial TLS patch References: <3D23129A.8070207@ges.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00132.txt.bz2 > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE); > >> >> Tipo OBJFILE -> objfile. > > > It was capitalized to match the comment above: > > + /* Return the so_list entry whose object file is OBJFILE. */ > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE); > + > > But the rest of GDB doesn't do that, so I'll change this. Just FYI, from the coding doco: > The comment on a function is much clearer if you use the argument names to speak about the argument values. The variable name itself should be lower case, but write it in upper case when you are speaking about the value rather than the variable itself. Thus, "the inode number NODE_NUM" rather than "an inode". enjoy, Andrew