From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16584-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 25591 invoked by alias); 28 Jun 2002 22:39:03 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25576 invoked from network); 28 Jun 2002 22:39:01 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 28 Jun 2002 22:39:01 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id D3F563C2B; Fri, 28 Jun 2002 18:38:59 -0400 (EDT)
Message-ID: <3D1CE583.4090801@ges.redhat.com>
Date: Fri, 28 Jun 2002 15:39:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] dummy frames using regcache
References: <3D1A1F43.6090405@ges.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-06/txt/msg00578.txt.bz2

> Hello,
> 
> Attached is the next in the regcache series.  This converts dummy frames to the regcache.  Tested on the i386.
> 
> Note the fixme though:
> 
> +      /* FIXME: cagney/2002-06-26: This should be via the
> +         gdbarch_register_read() method so that it, on the fly,
> +         constructs either a raw or pseudo register from the raw
> +         register cache.  */
> +      regcache_read (registers, regnum, bufferp);

FYI,

> 2002-06-26  Andrew Cagney  <ac131313@redhat.com>
> 
> 	* blockframe.c (generic_find_dummy_frame): Change return type to
> 	``struct regcache''.
> 	(struct dummy_frame): Replace field ``registers'' with regcache, a
> 	struct regcache object.
> 	(generic_find_dummy_frame): Update.
> 	(generic_push_dummy_frame): Update.  Use regcache_xfree,
> 	regcache_xmalloc and regcache_cpy.
> 	(generic_pop_dummy_frame): Update.  Use regcache_cpy and
> 	regcache_xfree.
> 	(deprecated_generic_find_dummy_frame): Update.
> 	(generic_read_register_dummy): Update.  Use
> 	regcache_read_as_address.
> 	(generic_call_dummy_register_unwind): Update.  Use regcache_read.
> 

I've now checked this in (.....holds breath ...).

Andrew