From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32080 invoked by alias); 28 Jun 2002 21:20:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32069 invoked from network); 28 Jun 2002 21:20:57 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 28 Jun 2002 21:20:57 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0B86F3E9C; Fri, 28 Jun 2002 17:20:56 -0400 (EDT) Message-ID: <3D1CD337.2010205@ges.redhat.com> Date: Fri, 28 Jun 2002 14:20:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: obrien@FreeBSD.org, gdb-patches@sources.redhat.com Subject: Re: [5.2.1] quiet warnings for gdbreplay.c References: <20020627204720.A13445@dragon.nuxi.com> <3D1C8AEF.5020508@ges.redhat.com> <20020628180820.GA9115@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00574.txt.bz2 > On Fri, Jun 28, 2002 at 12:12:31PM -0400, Andrew Cagney wrote: > >> >+#ifdef HAVE_STRING_H >> >+#include >> >+#endif > >> >> Should that bit be "gdb_string.h"? > > > That depends :) gdbreplay is not part of GDB and has a different > config.h header (tests for a different set of macros). (We could always fix that - eliminate that configure file :-^ ) More seriously, I think someone hacking on gdbreplay is likely to also be hacking on GDB. Consequently, they are going to expect the two directories to follow the same coding conventions. I had > eliminated all references to the gdb source code but then I introduced > an include of "gdb_proc_service.h", since the alternative was just > duplicating it; I have the feeling we should move that and headers like > gdb_string.h somewhere common - are they include/gdb/ candidates? You mean #include "gdb/gdb_string.h"? I think include/gdb/ is for external interfaces that are at some level controlled by GDB. Andrew