From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1656 invoked by alias); 26 Jun 2002 02:57:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1584 invoked from network); 26 Jun 2002 02:57:38 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 26 Jun 2002 02:57:38 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7A9603C62; Tue, 25 Jun 2002 22:57:16 -0400 (EDT) Message-ID: <3D192D8C.7000308@cygnus.com> Date: Tue, 25 Jun 2002 19:57:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613 X-Accept-Language: en-us, en MIME-Version: 1.0 To: tromey@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: gettextize jv-exp.y References: <87bs9zhp7c.fsf@fleche.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00524.txt.bz2 > This patch gettextizes jv-exp.y. > > In this case one code change was required. Look at yyerror(). > Also I fixed a couple of typos while I was at it. I would have ignored it but you mentioned fixing typos. Some more .. > > ClassInstanceCreationExpression: > NEW ClassType '(' ArgumentList_opt ')' > - { error ("FIXME - ClassInstanceCreationExpression"); } > + { error (_("FIXME - ClassInstanceCreationExpression")); } internal_error (_("...")); > ArgumentList: > @@ -408,9 +408,9 @@ > > ArrayCreationExpression: > NEW PrimitiveType DimExprs Dims_opt > - { error ("FIXME - ArrayCreatiionExpression"); } > + { error (_("FIXME - ArrayCreationExpression")); } > | NEW ClassOrInterfaceType DimExprs Dims_opt > - { error ("FIXME - ArrayCreatiionExpression"); } > + { error (_("FIXME - ArrayCreationExpression")); } Ditto. > DimExprs: > @@ -445,11 +445,11 @@ > > MethodInvocation: > Name '(' ArgumentList_opt ')' > - { error ("method invocation not implemented"); } > + { error (_("method invocation not implemented")); } Leading capital letter in error message. > | Primary '.' SimpleName '(' ArgumentList_opt ')' > - { error ("method invocation not implemented"); } > + { error (_("method invocation not implemented")); } > | SUPER '.' SimpleName '(' ArgumentList_opt ')' > - { error ("method invocation not implemented"); } > + { error (_("method invocation not implemented")); } > ; Ditto. > ArrayAccess: > @@ -539,7 +539,7 @@ > int i; > int base = expout_ptr - last_exp_size - 3; > if (base < 0 || expout->elts[base+2].opcode != OP_TYPE) > - error ("invalid cast expression"); > + error (_("invalid cast expression")); Ditto. > type = expout->elts[base+1].type; > /* Remove the 'Expression' and slide the > UnaryExpressionNotPlusMinus down to replace it. */ > @@ -795,7 +795,7 @@ > return ERROR; > if (n > limit_div_base > || (n *= base) > limit - c) > - error ("Numeric constant too large."); > + error (_("Numeric constant too large.")); I'm not 100% certain but I believe the intent, in GDB is for error messages to not include the period? > - error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr); > + if (msg) > + error (_("%s: near `%s'."), lexptr); The above is wrong, shouldn't --enable-gdb-warnings=,-Werror be detecting this? It includes -Wprintf. Andrew