Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: add_setshow_cmd_full
Date: Tue, 25 Jun 2002 19:35:00 -0000	[thread overview]
Message-ID: <3D192849.3080904@cygnus.com> (raw)
In-Reply-To: <878z53dqr9.fsf@fleche.redhat.com>

[fernando asked me to pick up a bit of this]


> 2002-06-25  Tom Tromey  <tromey@redhat.com>
> 
> 	* cli/cli-decode.c (add_setshow_cmd_full): New function.
> 	(add_setshow_cmd): Use it.
> 	* command.h (add_setshow_cmd_full): Declare.

Please be careful to configure GDB with 
--enable-gdb-build-warnings=,-Werror so that it is compiled with the 
-Werror flag.

Anyway, this is wrong ...

 > +extern struct cmd_list_element *add_setshow_cmd_full (char *name,
 > +		 
			      enum command_class class,

But this is approved ....

> +void
> +add_setshow_cmd_full (char *name,
> +		      enum command_class class,
> +		      var_types var_type, void *var,
> +		      char *set_doc, char *show_doc,
> +		      cmd_sfunc_ftype *set_func, cmd_sfunc_ftype *show_func,
> +		      struct cmd_list_element **set_list,
> +		      struct cmd_list_element **show_list,
> +		      struct cmd_list_element **set_result,
> +		      struct cmd_list_element **show_result)

Don't forget to remove they stray declaration:

> +extern struct cmd_list_element *add_setshow_cmd (char *name,
> +						 enum command_class class,
> +						 var_types var_type, void *var,
> +						 char *set_doc, char *show_doc,

from the change.

Andrew



  reply	other threads:[~2002-06-26  2:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-25 13:40 Tom Tromey
2002-06-25 19:35 ` Andrew Cagney [this message]
2002-06-25 22:12   ` Tom Tromey
2002-06-26  7:40     ` Andrew Cagney
2002-06-26 10:56       ` Tom Tromey
2002-06-26 12:54         ` Andrew Cagney
2002-06-25 22:05 ` Eli Zaretskii
2002-06-25 22:13   ` Tom Tromey
2002-06-26 11:23   ` Tom Tromey
2002-06-26 11:46     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D192849.3080904@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox