From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16454-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 2920 invoked by alias); 21 Jun 2002 22:13:23 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 2900 invoked from network); 21 Jun 2002 22:13:20 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 21 Jun 2002 22:13:20 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 86AFE3D66; Fri, 21 Jun 2002 18:13:20 -0400 (EDT)
Message-ID: <3D13A500.4070609@cygnus.com>
Date: Fri, 21 Jun 2002 15:13:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
Cc: Elena Zannoni <ezannoni@redhat.com>,
	gdb-patches@sources.redhat.com
Subject: Re: RFA: start of i18n
References: <87elf0wnp2.fsf@fleche.redhat.com> <15635.26155.499501.230768@localhost.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-06/txt/msg00448.txt.bz2

> Cool. The main.c part is approved.

And the rest.  Just suggest moving:

>  > +#ifdef HAVE_LOCALE_H
>  > +# include <locale.h>
>  > +#endif
>  > +
>  > +#ifdef ENABLE_NLS
>  > +# include <libintl.h>
>  > +# define _(String) gettext (String)
>  > +# ifdef gettext_noop
>  > +#  define N_(String) gettext_noop (String)
>  > +# else
>  > +#  define N_(String) (String)
>  > +# endif
>  > +#else
>  > +# define gettext(Msgid) (Msgid)
>  > +# define dgettext(Domainname, Msgid) (Msgid)
>  > +# define dcgettext(Domainname, Msgid, Category) (Msgid)
>  > +# define textdomain(Domainname) while (0) /* nothing */
>  > +# define bindtextdomain(Domainname, Dirname) while (0) /* nothing */
>  > +# define _(String) (String)
>  > +# define N_(String) (String)
>  > +#endif
>  > +

to "gdb_locale.h" and then including that.

Does src/Makefile.in:all-gdb need any dependency tweaks?

_("dontforgettheaeroguardandavagoodweekend")
Andrew