Re: [RFA] remove calls to fprintf in language parsers

[Andrew Cagney <ac131313@cygnus.com>]

> At 02:49 21/06/2002 , Andrew Cagney a écrit:
> 
>>>+/* Function used to avoid direct calls to fprintf
>>>+   in the code generated by the bison parser.  */
>>>+
>>>+extern void parser_fprintf (FILE *, const char *, ...);
> 
>>
>>Hmm, wonder if there is any benefit in adding ATTR_FORMAT(printf, 2, 3) to the declaration?
> 
> 
> I didn't even  know this modifier :(

BTW, attr_format was only added to error() (one of GDBs most important 
functions) a month or so ago.  While the attribute has been around for a 
while, it is relativly new for GDB.

> But it does look appropriate indeed.

My only reservation was that bison/yacc could turn out to generate badly 
formatted printf statements.  However, if that is happening then we need 
to know anyway.

As for indentation.  GNU indent doesn't handle ATTR_FORMAT() very well 
so any location is likely ok.

>>Anyway, yes,
> 
> 
> Does this mean I can apply the patch?

Yes, either way.

Andrew
(I'm just happy to see these fprintf() slowly disappearing :-)