From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25874 invoked by alias); 21 Jun 2002 03:31:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25817 invoked from network); 21 Jun 2002 03:31:25 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 21 Jun 2002 03:31:25 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id F0F053E2F; Thu, 20 Jun 2002 23:31:17 -0400 (EDT) Message-ID: <3D129E05.5080504@cygnus.com> Date: Thu, 20 Jun 2002 20:31:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dave Brolley Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] New Target - Fujitsu FRV References: <3D079928.50303@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00415.txt.bz2 > +/*#define HAVE_STEPPABLE_WATCHPOINT 1*/ > + > +#define STOPPED_BY_WATCHPOINT(W) \ > + ((W).kind == TARGET_WAITKIND_STOPPED \ > + && (W).value.sig == TARGET_SIGNAL_TRAP \ > + && (frv_stopped_data_address() != ((CORE_ADDR)0))) > +extern CORE_ADDR frv_stopped_data_address(void); > + > +/* Use these macros for watchpoint insertion/deletion. */ > +#define target_insert_watchpoint(addr, len, type) \ > + remote_insert_watchpoint (addr, len, type) > +#define target_remove_watchpoint(addr, len, type) \ > + remote_remove_watchpoint (addr, len, type) > +#define target_insert_hw_breakpoint(addr, shadow) \ > + remote_insert_hw_breakpoint (addr, 1) > +#define target_remove_hw_breakpoint(addr, shadow) \ > + remote_remove_hw_breakpoint (addr, 1) > +#define target_stopped_data_address() frv_stopped_data_address() > + > +/* These declarations should be in remote.h, no? */ > +extern int remote_insert_watchpoint (CORE_ADDR addr, int len, int type); > +extern int remote_remove_watchpoint (CORE_ADDR addr, int len, int type); > +extern int remote_insert_hw_breakpoint (CORE_ADDR addr, int len); > +extern int remote_remove_hw_breakpoint (CORE_ADDR addr, int len); Sigh! Another target and still the hardware breakpoint problem isn't fixed. I did some digging and I note you are not the author here :-) > +SIM_OBS = remote-sim.o > +SIM = ../sim/frv/libsim.a For the moment leave these out, but otherwize approved. Once committed, can you please check http://sources.redhat.com/gdb/current/ari/ for anything identifed (at the page top) from these new files. Can you also try building with --enable-gdb-build-warnings=,-Werror. Fixes related to both of these are considered obvious. enjoy, Andrew