From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23813 invoked by alias); 20 Jun 2002 13:08:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23805 invoked from network); 20 Jun 2002 13:08:38 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 20 Jun 2002 13:08:38 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id AE1F259D34C; Thu, 20 Jun 2002 15:08:37 +0200 (CEST) Received: from suse.cz (naga.suse.cz [10.20.1.16]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g5KD8b013091; Thu, 20 Jun 2002 15:08:37 +0200 X-Authentication-Warning: chimera.suse.cz: Host naga.suse.cz [10.20.1.16] claimed to be suse.cz Message-ID: <3D11D3D5.3080602@suse.cz> Date: Thu, 20 Jun 2002 06:08:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020529 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] another const char *register_name() References: <3D109C94.6050205@cygnus.com> Content-Type: multipart/mixed; boundary="------------040008040604030007010408" X-SW-Source: 2002-06/txt/msg00395.txt.bz2 This is a multi-part message in MIME format. --------------040008040604030007010408 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 174 My two cents to this thread. Just some renaming ... committed as obvious. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz --------------040008040604030007010408 Content-Type: text/plain; name="regname.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="regname.diff" Content-length: 5046 2002-06-19 Michal Ludvig * x86-64-tdep.c (x86_64_register_nr2name): Rename to=20 x86_64_register_name. Return type changed to 'const char *'. (x86_64_register_name2nr): Rename to x86_64_register_number. (x86_64_gdbarch_init): Update to reflect the change. * x86-64-tdep.h: Ditto. * x86-64-linux-nat.c (x86_64_fxsave_offset) (supply_fpregset): Ditto. Index: x86-64-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/x86-64-tdep.c,v retrieving revision 1.23 diff -c -3 -p -r1.23 x86-64-tdep.c *** x86-64-tdep.c 14 Jun 2002 22:55:41 -0000 1.23 --- x86-64-tdep.c 20 Jun 2002 12:52:09 -0000 *************** x86_64_store_return_value (struct type * *** 798,805 **** } =0C =20=20 ! char * ! x86_64_register_nr2name (int reg_nr) { if (reg_nr < 0 || reg_nr >=3D X86_64_NUM_REGS) return NULL; --- 798,805 ---- } =0C =20=20 ! const char * ! x86_64_register_name (int reg_nr) { if (reg_nr < 0 || reg_nr >=3D X86_64_NUM_REGS) return NULL; *************** x86_64_register_nr2name (int reg_nr) *** 807,813 **** } =20=20 int ! x86_64_register_name2nr (const char *name) { int reg_nr; =20=20 --- 807,813 ---- } =20=20 int ! x86_64_register_number (const char *name) { int reg_nr; =20=20 *************** x86_64_gdbarch_init (struct gdbarch_info *** 989,995 **** set_gdbarch_long_double_format (gdbarch, &floatformat_i387_ext); =20=20 set_gdbarch_num_regs (gdbarch, X86_64_NUM_REGS); ! set_gdbarch_register_name (gdbarch, x86_64_register_nr2name); set_gdbarch_register_size (gdbarch, 8); set_gdbarch_register_raw_size (gdbarch, x86_64_register_raw_size); set_gdbarch_max_register_raw_size (gdbarch, 16); --- 989,995 ---- set_gdbarch_long_double_format (gdbarch, &floatformat_i387_ext); =20=20 set_gdbarch_num_regs (gdbarch, X86_64_NUM_REGS); ! set_gdbarch_register_name (gdbarch, x86_64_register_name); set_gdbarch_register_size (gdbarch, 8); set_gdbarch_register_raw_size (gdbarch, x86_64_register_raw_size); set_gdbarch_max_register_raw_size (gdbarch, 16); Index: x86-64-tdep.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/x86-64-tdep.h,v retrieving revision 1.4 diff -c -3 -p -r1.4 x86-64-tdep.h *** x86-64-tdep.h 7 Jun 2002 16:11:09 -0000 1.4 --- x86-64-tdep.h 20 Jun 2002 12:52:09 -0000 *************** *** 28,35 **** extern int x86_64_num_regs; extern int x86_64_num_gregs; =20=20 ! int x86_64_register_name2nr (const char *name); ! char *x86_64_register_nr2name (int reg_nr); =20=20 gdbarch_frame_saved_pc_ftype x86_64_linux_frame_saved_pc; gdbarch_saved_pc_after_call_ftype x86_64_linux_saved_pc_after_call; --- 28,36 ---- extern int x86_64_num_regs; extern int x86_64_num_gregs; =20=20 ! int x86_64_register_number (const char *name); ! const char *x86_64_register_name (int reg_nr); !=20=09 =20=20 gdbarch_frame_saved_pc_ftype x86_64_linux_frame_saved_pc; gdbarch_saved_pc_after_call_ftype x86_64_linux_saved_pc_after_call; Index: x86-64-linux-nat.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/x86-64-linux-nat.c,v retrieving revision 1.13 diff -c -3 -p -r1.13 x86-64-linux-nat.c *** x86-64-linux-nat.c 7 Jun 2002 16:11:09 -0000 1.13 --- x86-64-linux-nat.c 20 Jun 2002 12:52:09 -0000 *************** store_regs (int tid, int regno) *** 197,208 **** static void * x86_64_fxsave_offset (elf_fpregset_t * fxsave, int regnum) { ! char *reg_name; int reg_index; =20=20 gdb_assert (x86_64_num_gregs - 1 < regnum && regnum < x86_64_num_regs); =20=20 ! reg_name =3D x86_64_register_nr2name (regnum); =20=20 if (reg_name[0] =3D=3D 's' && reg_name[1] =3D=3D 't') { --- 197,208 ---- static void * x86_64_fxsave_offset (elf_fpregset_t * fxsave, int regnum) { ! const char *reg_name; int reg_index; =20=20 gdb_assert (x86_64_num_gregs - 1 < regnum && regnum < x86_64_num_regs); =20=20 ! reg_name =3D x86_64_register_name (regnum); =20=20 if (reg_name[0] =3D=3D 's' && reg_name[1] =3D=3D 't') { *************** supply_fpregset (elf_fpregset_t * fxsave *** 231,238 **** { int i, reg_st0, reg_mxcsr; =20=20 ! reg_st0 =3D x86_64_register_name2nr ("st0"); ! reg_mxcsr =3D x86_64_register_name2nr ("mxcsr"); =20=20 gdb_assert (reg_st0 > 0 && reg_mxcsr > reg_st0); =20=20 --- 231,238 ---- { int i, reg_st0, reg_mxcsr; =20=20 ! reg_st0 =3D x86_64_register_number ("st0"); ! reg_mxcsr =3D x86_64_register_number ("mxcsr"); =20=20 gdb_assert (reg_st0 > 0 && reg_mxcsr > reg_st0); =20=20 --------------040008040604030007010408--