From: Andrew Cagney <ac131313@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [rfa/testsuite] One pass/fail per expect list
Date: Fri, 14 Jun 2002 12:46:00 -0000 [thread overview]
Message-ID: <3D0A4801.8030001@cygnus.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
Hello,
The attached tweaks gdb_expect_list{} so that it only prints one pass /
fail / ... message for the testcase.
What are peoples thoughts on this change and if positive, is the patch ok?
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1860 bytes --]
2002-06-14 Andrew Cagney <ac131313@redhat.com>
* lib/gdb.exp (gdb_expect_list): Only print one pass, fail, or
supress message.
Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.20
diff -u -r1.20 gdb.exp
--- lib/gdb.exp 11 Jun 2002 20:37:05 -0000 1.20
+++ lib/gdb.exp 14 Jun 2002 19:21:30 -0000
@@ -1265,6 +1265,7 @@
set ok 1
if { $suppress_flag } {
set ok 0
+ unresolved "${test}"
}
while { ${index} < [llength ${list}] } {
set pattern [lindex ${list} ${index}]
@@ -1273,41 +1274,42 @@
if { ${ok} } {
gdb_expect {
-re "${pattern}${sentinel}" {
- pass "${test}, pattern ${index} + sentinel"
+ # pass "${test}, pattern ${index} + sentinel"
}
-re "${sentinel}" {
- fail "${test}, pattern ${index} + sentinel"
+ fail "${test} (pattern ${index} + sentinel)"
set ok 0
}
timeout {
- fail "${test}, pattern ${index} + sentinel (timeout)"
+ fail "${test} (pattern ${index} + sentinel) (timeout)"
set ok 0
}
}
} else {
- unresolved "${test}, pattern ${index} + sentinel"
+ # unresolved "${test}, pattern ${index} + sentinel"
}
} else {
if { ${ok} } {
gdb_expect {
-re "${pattern}" {
- pass "${test}, pattern ${index}"
+ # pass "${test}, pattern ${index}"
}
-re "${sentinel}" {
- fail "${test}, pattern ${index}"
+ fail "${test} (pattern ${index})"
set ok 0
}
timeout {
- fail "${test}, pattern ${index} (timeout)"
+ fail "${test} (pattern ${index}) (timeout)"
set ok 0
}
}
} else {
- unresolved "${test}, pattern ${index}"
+ # unresolved "${test}, pattern ${index}"
}
}
}
if { ${ok} } {
+ pass "${test}"
return 0
} else {
return 1
next reply other threads:[~2002-06-14 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-14 12:46 Andrew Cagney [this message]
2002-08-01 14:49 ` Fernando Nasser
2002-08-01 15:09 ` Andrew Cagney
2002-08-05 15:55 ` Kevin Buettner
2002-08-05 20:57 ` Andrew Cagney
2002-08-06 15:46 ` Kevin Buettner
2002-08-07 12:11 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D0A4801.8030001@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox