From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17061 invoked by alias); 9 Jun 2002 16:20:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17035 invoked from network); 9 Jun 2002 16:20:24 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 9 Jun 2002 16:20:24 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id AE9043EA2; Sun, 9 Jun 2002 12:20:02 -0400 (EDT) Message-ID: <3D038031.4010607@cygnus.com> Date: Sun, 09 Jun 2002 09:20:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc3) Gecko/20020530 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA]: Adapt solib-svr4.c for recent gdbarch_data changes References: <200206091526.g59FQQ405652@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00144.txt.bz2 > Discovered this moring that my gdb was crashing. Seems like we have > an initialization cycle here. I think that after Andrew's patch we > can simplify init_fetch_link_map_offsets as in the attached patch. Oops! The target I tried this on sets the link map offset. (So this also means that the cycle test works?) > OK to check this in? > * solib-svr4.c (init_fetch_link_map_offsets): Simply return > legacy_fetch_link_map_offsets. Adjust comment to reflect reality > after Andrew's 2002-06-08 gdbarch change. I think it might have to go under an ``obvious fix''. I definitly broke the code and the way you've changed things is the only way to do it. I think I'll update the [about to commit] doco to reflect this. Andrew