From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16000-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 16001 invoked by alias); 31 May 2002 17:21:50 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15972 invoked from network); 31 May 2002 17:21:46 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 31 May 2002 17:21:46 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 0875D3D94; Fri, 31 May 2002 13:21:17 -0400 (EDT)
Message-ID: <3CF7B10C.4050805@cygnus.com>
Date: Fri, 31 May 2002 11:55:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc3) Gecko/20020530
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Don Howard <dhoward@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Small memattr fix
References: <Pine.LNX.4.33.0205301759350.8589-100000@theotherone>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-05/txt/msg01048.txt.bz2

> The following patch fixes gdb's bogus complaint that 
> 
> 	mem 0x0 0x04 ...
> 
> overlaps with 
> 
> 	mem 0x4 0x08 ...

Hmm, checking:

    http://sources.redhat.com/gdb/current/onlinedocs/gdb_9.html#IDX375

it indicates that the upper bound is exclusive (see under `info mem') so 
yes definitly, good catch.

Perhaphs [separate problem] the doco should mention this earlier and 
more clearly?

enjoy,
Andrew

> 2002-05-30  Don Howard  <dhoward@redhat.com>
> 
> 	* memattr.c (create_mem_region): Don't include upper address in
> 	test for overlapping mem regions.
> 
> Index: memattr.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/memattr.c,v
> retrieving revision 2.5.22.1
> diff -p -u -w -r2.5.22.1 memattr.c
> --- memattr.c   2002/02/05 00:31:36     2.5.22.1
> +++ memattr.c   2002/05/31 00:55:20
> @@ -55,8 +55,8 @@ create_mem_region (CORE_ADDR lo, CORE_AD
>    while (n)
>      {
>        /* overlapping node */
> -      if ((lo >= n->lo && lo <= n->hi) ||
> -         (hi >= n->lo && hi <= n->hi))
> +      if ((lo >= n->lo && lo < n->hi) ||
> +         (hi > n->lo && hi <= n->hi))
>         {
>           printf_unfiltered ("overlapping memory region\n");
>           return NULL;