From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17710 invoked by alias); 24 May 2002 00:38:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17669 invoked from network); 24 May 2002 00:38:07 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 24 May 2002 00:38:07 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id RAA20389; Thu, 23 May 2002 17:38:05 -0700 (PDT) Message-ID: <3CED8819.3CD1AE95@redhat.com> Date: Thu, 23 May 2002 18:25:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney , Michael Snyder , gdb-patches@sources.redhat.com, ezannoni@redhat.com Subject: Re: [PATCH] Update D10V generic_dummy calls References: <200205231538.g4NFcam31809@reddwarf.sfbay.redhat.com> <3CED74F0.5060908@cygnus.com> <3CED8357.752C2FD2@redhat.com> <3CED83FD.7067A4E3@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00889.txt.bz2 Michael Snyder wrote: > > Michael Snyder wrote: > > > > Andrew Cagney wrote: > > > > > > > 2002-05-22 Michael Snyder > > > > > > > > * d10v-tdep.c: Change a few macros to enums for ease of debugging. > > > > (d10v_frame_chain_valid): Add PC_IN_CALL_DUMMY clause. > > > > (d10v_frame_saved_pc): Add PC_IN_CALL_DUMMY clause. > > > > (d10v_frame_chain): Bail immediately if PC_IN_CALL_DUMMY. > > > > Don't bail if return_pc is PC_IN_CALL_DUMMY. > > > > Add a temp variable to save a call (and a memory read). > > > > (d10v_init_extra_frame_info): Get fi->pc from callee's return_pc > > > > if possible (so that PC_IN_CALL_DUMMY will work). > > > > > > > > > > Michael, > > > > > > This patch: > > > > > > > *************** d10v_gdbarch_init (struct gdbarch_info i > > > > *** 1486,1492 **** > > > > set_gdbarch_register_byte (gdbarch, d10v_register_byte); > > > > set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size); > > > > set_gdbarch_max_register_raw_size (gdbarch, 8); > > > > ! set_gdbarch_register_virtual_size (gdbarch, generic_register_size); > > > > set_gdbarch_max_register_virtual_size (gdbarch, 8); > > > > set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type); > > > > > > > > --- 1525,1531 ---- > > > > set_gdbarch_register_byte (gdbarch, d10v_register_byte); > > > > set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size); > > > > set_gdbarch_max_register_raw_size (gdbarch, 8); > > > > ! set_gdbarch_register_virtual_size (gdbarch, generic_register_virtual_size); > > > > set_gdbarch_max_register_virtual_size (gdbarch, 8); > > > > set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type); > > > > > > > > > > Wasn't mentioned in the change log and breaks d10v builds :-( > > > > Eh? I don't remember doing that... > > > > Oh! My source tree isn't up to date! > > Sorry about that -- please withdraw this patch and I'll re-submit. > > Good thing I hadn't gotten around to checking it in yet... > > Wait a minute -- I did check it in. But evidently it was > not in sync. I can't understand how this could have happened. Argh. Well, Andrew, I've verified that you succeeded in straightening out my mess. Thank you. The file is as it should be now.