Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <ac131313@cygnus.com>,
	Michael Snyder <msnyder@cygnus.com>,
	gdb-patches@sources.redhat.com, ezannoni@redhat.com
Subject: Re: [PATCH] Update D10V generic_dummy calls
Date: Thu, 23 May 2002 17:38:00 -0000	[thread overview]
Message-ID: <3CED83FD.7067A4E3@redhat.com> (raw)
In-Reply-To: <3CED8357.752C2FD2@redhat.com>

Michael Snyder wrote:
> 
> Andrew Cagney wrote:
> >
> > > 2002-05-22  Michael Snyder  <msnyder@redhat.com>
> > >
> > >       * d10v-tdep.c: Change a few macros to enums for ease of debugging.
> > >       (d10v_frame_chain_valid): Add PC_IN_CALL_DUMMY clause.
> > >       (d10v_frame_saved_pc): Add PC_IN_CALL_DUMMY clause.
> > >       (d10v_frame_chain): Bail immediately if PC_IN_CALL_DUMMY.
> > >       Don't bail if return_pc is PC_IN_CALL_DUMMY.
> > >       Add a temp variable to save a call (and a memory read).
> > >       (d10v_init_extra_frame_info): Get fi->pc from callee's return_pc
> > >       if possible (so that PC_IN_CALL_DUMMY will work).
> > >
> >
> > Michael,
> >
> > This patch:
> >
> > > *************** d10v_gdbarch_init (struct gdbarch_info i
> > > *** 1486,1492 ****
> > >     set_gdbarch_register_byte (gdbarch, d10v_register_byte);
> > >     set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size);
> > >     set_gdbarch_max_register_raw_size (gdbarch, 8);
> > > !   set_gdbarch_register_virtual_size (gdbarch, generic_register_size);
> > >     set_gdbarch_max_register_virtual_size (gdbarch, 8);
> > >     set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type);
> > >
> > > --- 1525,1531 ----
> > >     set_gdbarch_register_byte (gdbarch, d10v_register_byte);
> > >     set_gdbarch_register_raw_size (gdbarch, d10v_register_raw_size);
> > >     set_gdbarch_max_register_raw_size (gdbarch, 8);
> > > !   set_gdbarch_register_virtual_size (gdbarch, generic_register_virtual_size);
> > >     set_gdbarch_max_register_virtual_size (gdbarch, 8);
> > >     set_gdbarch_register_virtual_type (gdbarch, d10v_register_virtual_type);
> > >
> >
> > Wasn't mentioned in the change log and breaks d10v builds :-(
> 
> Eh?  I don't remember doing that...
> 
> Oh!  My source tree isn't up to date!
> Sorry about that -- please withdraw this patch and I'll re-submit.
> Good thing I hadn't gotten around to checking it in yet...

Wait a minute -- I did check it in.  But evidently it was
not in sync.  I can't understand how this could have happened.


  reply	other threads:[~2002-05-24  0:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-23  9:05 Michael Snyder
2002-05-23 16:41 ` Andrew Cagney
2002-05-23 17:17   ` Andrew Cagney
2002-05-23 17:18   ` Michael Snyder
2002-05-23 17:38     ` Michael Snyder [this message]
2002-05-23 18:25       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CED83FD.7067A4E3@redhat.com \
    --to=msnyder@redhat.com \
    --cc=ac131313@cygnus.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox