From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18592 invoked by alias); 23 May 2002 17:07:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18555 invoked from network); 23 May 2002 17:07:11 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 23 May 2002 17:07:11 -0000 Received: from telocity.telocity.com (romulus.sfbay.redhat.com [172.16.27.251]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id KAA12247; Thu, 23 May 2002 10:06:58 -0700 (PDT) Message-ID: <3CED2183.3B7A@redhat.com> Date: Thu, 23 May 2002 10:21:00 -0000 From: Michael Snyder MIME-Version: 1.0 To: Andrew Cagney CC: Michael Snyder , fnasser@redhat.com, Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add "needs_status_wrapper" feature to gdb testsuite. References: <200205070035.g470ZL426477@reddwarf.sfbay.redhat.com> <3CDC24BE.50203@cygnus.com> <3CED1429.9020908@cygnus.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00873.txt.bz2 Andrew Cagney wrote: > > > This is a feature that has been being used in the GCC testsuite, but I was completely unaware of it before now. > > Michael, this is _still_ broken. Sorry -- I think there's a fix in-house: I've just been too busy to push it out to sources. I'll do it today. > > > This enables tests that look for an exit status to succeed even > > on targets that don't implement the exit status. I think it's > > pretty cool! > > > > I've modified two tests from gdb/testsuite to take advantage of it. > > I'm not sure which other tests may also need modification, but > > now there are a couple of examples to look at. > > > > Index: lib/gdb.exp > > =================================================================== > > RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v > > retrieving revision 1.15 > > diff -p -r1.15 gdb.exp > > *** lib/gdb.exp 3 Apr 2002 16:17:11 -0000 1.15 > > --- lib/gdb.exp 7 May 2002 00:10:06 -0000 > > *************** proc gdb_preprocess {source dest args} { > > *** 1092,1099 **** > > --- 1092,1125 ---- > > return $result; > > } > > + set gdb_wrapper_initialized 0 > > + + proc gdb_wrapper_init { args } { > > + global gdb_wrapper_initialized; > > + global gdb_wrapper_file; > > + global gdb_wrapper_flags; > > > > return; > > > > + if { $gdb_wrapper_initialized == 1 } { return; } > > + + if {[target_info exists needs_status_wrapper] && \ > > + [target_info needs_status_wrapper] != "0" && \ > > + ![info exists gdb_wrapper_file]} { > > + set result [build_wrapper "testglue.o"]; > > + if { $result != "" } { > > + set gdb_wrapper_file [lindex $result 0]; > > + set gdb_wrapper_flags [lindex $result 1]; > > + } else { > > + warning "Status wrapper failed to build." > > + } > > + } > > + set gdb_wrapper_initialized 1 > > + } > > +