From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19955 invoked by alias); 20 May 2002 17:34:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19948 invoked from network); 20 May 2002 17:34:06 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 20 May 2002 17:34:06 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 37E143CB7; Mon, 20 May 2002 13:34:09 -0400 (EDT) Message-ID: <3CE93391.5060500@cygnus.com> Date: Mon, 20 May 2002 10:34:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc2) Gecko/20020518 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Keith Seitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/MI] Renumber enum mi_cmd_result References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00823.txt.bz2 > > Ugh. This turned out to be more elusive than I thought. After trying this > and that to untangle captured_mi_execute_command and catch_errors > (mi_execute_command used a return code that was a hybrid of both of > these), I've settled on the following patch, which at least attempts to > keep the mi return result of the command separate from what > mi_execute_command should do. > Looks like a good move. Yes. Andrew PS: catch_exceptions() is something of a compromise so I'm not suprized. One early prototype had the wrapped function returning void so code was forced to pass the result back via the argument.