From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8658 invoked by alias); 16 May 2002 22:35:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8612 invoked from network); 16 May 2002 22:35:17 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 16 May 2002 22:35:17 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 519BC3E3D; Thu, 16 May 2002 18:35:23 -0400 (EDT) Message-ID: <3CE4342B.10803@cygnus.com> Date: Thu, 16 May 2002 15:35:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc1) Gecko/20020429 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jason R Thorpe Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Generic OS ABI handling References: <20020513120839.X3435@dr-evil.shagadelic.org> <15588.11053.545829.689213@localhost.redhat.com> <20020516151705.Y4613@dr-evil.shagadelic.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00672.txt.bz2 > On Thu, May 16, 2002 at 05:57:01PM -0400, Elena Zannoni wrote: > > > I completely missed the fact that the sh-tdep.c changes were included > > here, sorry. > > No problem :-) > > > The sh* part is approved. A question, should be osabi.h be included > > in defs.h? I see that in one file you add both include osabi.h > > and defs.h. Another question, have you thought about whether this new > > generic mechanism applies to the rs6000-tdep.c file as well? If so, I > > can make the required changes. > > Ah, yes, I did put the inclusion of osabi.h into defs.h. I must > have missed the duplicate inclusion in osabi.c -- thanks for pointing > it out. Oh, thanks, I missed that. So, you're removing osabi.h from defs.h, right? We're trying to trim the size of the defs.h include list :-) Andrew > Yes, this new generic mechanism should work equally well for the rs6000. > So far, I have made the sh, alpha, arm, and mips targets use it (I've > posted patches for sh, alpha, and arm ... mips I will post when I post > my mips*-*-netbsd* configuration).