From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17125 invoked by alias); 16 May 2002 10:09:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17117 invoked from network); 16 May 2002 10:09:04 -0000 Received: from unknown (HELO uk.superh.com) (193.128.105.170) by sources.redhat.com with SMTP; 16 May 2002 10:09:04 -0000 Received: from sh-uk-ex01.uk.w2k.superh.com (sh-uk-ex01 [192.168.16.17]) by uk.superh.com (8.11.6+Sun/8.11.6) with ESMTP id g4GA4po03980; Thu, 16 May 2002 11:04:51 +0100 (BST) Received: from superh.com ([192.168.17.40]) by sh-uk-ex01.uk.w2k.superh.com with Microsoft SMTPSVC(5.0.2195.4905); Thu, 16 May 2002 11:07:26 +0100 Message-ID: <3CE3856B.35E95996@superh.com> Date: Thu, 16 May 2002 03:09:00 -0000 From: Joern Rennecke Organization: SuperH UK Ltd. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: gdb-patches@sources.redhat.com, Elena Zannoni Subject: Re: Enum constants for sh1-sh4, sh{3}-dsp register numbers in thesimulator References: <3CE24FEF.279A0207@superh.com> <3CE2C66F.90209@cygnus.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 16 May 2002 10:07:26.0244 (UTC) FILETIME=[7AD03E40:01C1FCC1] X-SW-Source: 2002-05/txt/msg00632.txt.bz2 Andrew Cagney wrote: > > > Index: include/gdb/sim-sh.h > > =================================================================== > > RCS file: /cvs/src/src/include/gdb/sim-sh.h,v > > retrieving revision 1.1 > One thought. > > This is a true enum and not a bunch of constants. Perhaphs it would be > better to simply list all the enum members. Do you mean to add SIM_SH_FR1_REGNUM .. SIM_SH_FR15_REGNUM and the various individual banked regnums? I could do that. OTOH, if you mean to remove the seed values like 24 for SIM_SH_DSR_REGNUM and 40 for SIM_SH_MOD_REGNUM, making a flat enum, that would break backwards compatibility, as we have some gaps, and overlaps between floating point and dsp registers. (This mirrors an overlap in the instruction set. In fact the instructions to manipulate FPSCR and DSR are the same, and the simulator makes use of this by treating them really as the same.) -- -------------------------- SuperH 2430 Aztec West / Almondsbury / BRISTOL / BS32 4AQ T:+44 1454 462330