From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15464-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 6578 invoked by alias); 13 May 2002 23:35:16 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6562 invoked from network); 13 May 2002 23:35:15 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 13 May 2002 23:35:15 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 78FCD3E16; Mon, 13 May 2002 19:35:24 -0400 (EDT)
Message-ID: <3CE04DBC.9040100@cygnus.com>
Date: Mon, 13 May 2002 16:35:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc1) Gecko/20020429
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jim blandy <jimb@redhat.com>, gdb-patches@sources.redhat.com
Subject: macrotab.c -Werror
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-05/txt/msg00512.txt.bz2

[second attempt at posting]

Jim,

FYI, I'm seeing:

gdb/macrotab.c:504: warning: `best_depth' might be used uninitialized in
this function
gmake: *** [macrotab.o] Error 1

for the code:

    /* It's not us.  Try all our children, and return the lowest.  */
    {
      struct macro_source_file *child;
      struct macro_source_file *best = 0;
      int best_depth;

      for (child = source->includes; child; child = child->next_included)
        {
          struct macro_source_file *result
            = macro_lookup_inclusion (child, name);

          if (result)
            {
              int result_depth = inclusion_depth (result);

              if (! best || result_depth < best_depth) <-- HERE
                {
                  best = result;
                  best_depth = result_depth;
                }
            }
        }

      return best;
    }

enjoy,
Andrew