From: Andrew Cagney <ac131313@cygnus.com>
To: davidm@hpl.hp.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: new gdb arch routine FRAME_UNCHANGED
Date: Mon, 13 May 2002 15:46:00 -0000 [thread overview]
Message-ID: <3CE04238.3060102@cygnus.com> (raw)
In-Reply-To: <15584.11515.164115.822423@napali.hpl.hp.com>
> Oh, by "opaque" I didn't mean a "void *". Just an object of a fixed
> size with an undefined structure. I agree that it's preferable to be
> able to declare automatic variables of this type. I was thinking of
> having an array of "void *" inside an struct, with the array size
> being architecture-specific.
Ah, ok. I guess `struct { CORE_ADDR x[3]; }'. If someone finds they
need more entries then we can just keep making it bigger. Trailing
unused entries are zero.
The reason for advising against pointers or variable size struct is that
these objects are not well managed in terms of malloc/delete. The ptid
is another example of the same thing of the same thing - no need to
worry about memory leaks.
> Andrew> However, gdbarch methods to fill in and compare frame_id's
> Andrew> could certainly be added.
>
> OK, that would probably do it. Do you see any need to calculate a
> hash or is comparison for equality sufficient?
Some existing code wants to compare based on just frame. See
stack.c:parse_frame_specification. Stop on first trailing zero?
Also, code wants to determine which code is more INNER_THAN(). With two
stacks, that starts to get really weird!
Andrew
next prev parent reply other threads:[~2002-05-13 22:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-10 17:23 David Mosberger
2002-05-10 18:04 ` Andrew Cagney
2002-05-10 19:05 ` David Mosberger
2002-05-11 20:52 ` Andrew Cagney
2002-05-13 14:15 ` David Mosberger
2002-05-13 15:46 ` Andrew Cagney [this message]
2002-05-13 15:57 ` Kevin Buettner
2002-05-13 16:14 ` Andrew Cagney
2002-05-13 19:43 ` David Mosberger
2002-05-13 19:57 ` Andrew Cagney
2002-05-13 20:33 ` David Mosberger
2002-06-26 20:26 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE04238.3060102@cygnus.com \
--to=ac131313@cygnus.com \
--cc=davidm@hpl.hp.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox