From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15289-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 16546 invoked by alias); 10 May 2002 16:09:15 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 16539 invoked from network); 10 May 2002 16:09:15 -0000
Received: from unknown (HELO tetsuo.nj.caldera.com) (63.124.204.226)
  by sources.redhat.com with SMTP; 10 May 2002 16:09:15 -0000
Received: from caldera.com (localhost.localdomain [127.0.0.1])
	by tetsuo.nj.caldera.com (8.11.6/8.11.6) with ESMTP id g4AGLLc06558;
	Fri, 10 May 2002 12:21:21 -0400
Message-ID: <3CDBF37E.5CA1393F@caldera.com>
Date: Fri, 10 May 2002 09:09:00 -0000
From: Petr Sorfa <petrs@caldera.com>
Organization: Caldera
X-Accept-Language: en
MIME-Version: 1.0
To: Kevin Buettner <kevinb@redhat.com>,
   "gdb-patches@sources.redhat.com" <gdb-patches@sources.redhat.com>
Subject: Re: [PATCH] IA64 fix for breakpoints on L in MLX instruction bundles
References: <3CDAAB19.4780AA1F@caldera.com> <1020509165617.ZM13420@localhost.localdomain> <3CDACD8D.3C6AA3FF@caldera.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-05/txt/msg00337.txt.bz2

Hi,

Committed.

Petr
> Hi Kevin,
> 
> My apologies, I'll fix the indentation.
> 
> Petr
> > On May 9,  1:00pm, Petr Sorfa wrote:
> >
> > > Patch for handling breakpoints on the L instruction type in an MLX
> > > bundle.
> > >
> > >
> > > 2002-05-09  Petr Sorfa (petrs@caldera.com)
> > >
> > >         * ia64-tdep.c: Handle breakpoints on L instruction type
> > >         in MLX instruction bundle by moving the breakpoint to
> > >         the third slot (X instruction type) as L holds only data.
> >
> > Approved, but I'd like you to fix a minor indentation issue prior
> > to committing it though...
> >
> > > +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> > > +   {
> > > +     slotnum = 2;
> > > +   }
> >
> > This should look like this instead:
> >
> > > +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> > > +     {
> > > +       slotnum = 2;
> > > +     }
> >
> > Or just:
> >
> > > +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> > > +     slotnum = 2;
> >
> > Thanks,
> >
> > Kevin