From: Petr Sorfa <petrs@caldera.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: "gdb-patches@sources.redhat.com" <gdb-patches@sources.redhat.com>
Subject: Re: [PATCH] IA64 fix for breakpoints on L in MLX instruction bundles
Date: Thu, 09 May 2002 12:15:00 -0000 [thread overview]
Message-ID: <3CDACD8D.3C6AA3FF@caldera.com> (raw)
In-Reply-To: <1020509165617.ZM13420@localhost.localdomain>
Hi Kevin,
My apologies, I'll fix the indentation.
Petr
> On May 9, 1:00pm, Petr Sorfa wrote:
>
> > Patch for handling breakpoints on the L instruction type in an MLX
> > bundle.
> >
> >
> > 2002-05-09 Petr Sorfa (petrs@caldera.com)
> >
> > * ia64-tdep.c: Handle breakpoints on L instruction type
> > in MLX instruction bundle by moving the breakpoint to
> > the third slot (X instruction type) as L holds only data.
>
> Approved, but I'd like you to fix a minor indentation issue prior
> to committing it though...
>
> > + if (slotnum == 1 && template_encoding_table[template][1] == L)
> > + {
> > + slotnum = 2;
> > + }
>
> This should look like this instead:
>
> > + if (slotnum == 1 && template_encoding_table[template][1] == L)
> > + {
> > + slotnum = 2;
> > + }
>
> Or just:
>
> > + if (slotnum == 1 && template_encoding_table[template][1] == L)
> > + slotnum = 2;
>
> Thanks,
>
> Kevin
next prev parent reply other threads:[~2002-05-09 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-09 9:48 Petr Sorfa
2002-05-09 9:56 ` Kevin Buettner
2002-05-09 12:15 ` Petr Sorfa [this message]
2002-05-10 9:09 ` Petr Sorfa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CDACD8D.3C6AA3FF@caldera.com \
--to=petrs@caldera.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox