From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10072 invoked by alias); 8 May 2002 23:52:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10064 invoked from network); 8 May 2002 23:52:22 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 8 May 2002 23:52:22 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA09864; Wed, 8 May 2002 16:52:19 -0700 (PDT) Message-ID: <3CD9B721.6207C70@redhat.com> Date: Wed, 08 May 2002 16:52:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: tromey@redhat.com CC: gdb-patches@sources.redhat.com Subject: Re: Patch: printing java `char' values References: <877kmh8a6r.fsf@creche.redhat.com> <3CD8429E.DA6D6BC7@redhat.com> <873cx3vdhy.fsf@creche.redhat.com> <3CD9756D.F0AE4AF@redhat.com> <87sn52l0at.fsf@creche.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00245.txt.bz2 Tom Tromey wrote: > > >>>>> "Michael" == Michael Snyder writes: > > Michael> I recommend that you emulate what C does, and whenever you > Michael> have a TYPE_CODE_INT whose length is the length of a char > Michael> (which for Java appears to be two bytes), you look at the > Michael> type_name and see if it is "char" -- in which case you print > Michael> it as a char. > > How does this look? Yes, that's the idea. I wouldn't even bother with the temp variable-- I would just call TYPE_CODE (type) twice. It's a macro, and not expensive to evaluate. Then you don't need the brackets. > > Index: ChangeLog > from Tom Tromey > > * jv-valprint.c (java_val_print): Handle `char' as a special case > of TYPE_CODE_INT. > > Index: jv-valprint.c > =================================================================== > RCS file: /cvs/src/src/gdb/jv-valprint.c,v > retrieving revision 1.9 > diff -u -r1.9 jv-valprint.c > --- jv-valprint.c 21 Oct 2001 01:57:42 -0000 1.9 > +++ jv-valprint.c 8 May 2002 22:41:22 -0000 > @@ -497,20 +499,21 @@ > return i; > > case TYPE_CODE_CHAR: > - format = format ? format : output_format; > - if (format) > - print_scalar_formatted (valaddr, type, format, 0, stream); > - else > - LA_PRINT_CHAR ((int) unpack_long (type, valaddr), stream); > - break; > - > case TYPE_CODE_INT: > /* Can't just call c_val_print because that print bytes as C chars. */ > format = format ? format : output_format; > if (format) > print_scalar_formatted (valaddr, type, format, 0, stream); > else > - val_print_type_code_int (type, valaddr, stream); > + { > + enum type_code code = TYPE_CODE (type); > + if (code == TYPE_CODE_CHAR > + || (code == TYPE_CODE_INT && TYPE_LENGTH (type) == 2 > + && ! strcmp (TYPE_NAME (type), "char"))) > + LA_PRINT_CHAR ((int) unpack_long (type, valaddr), stream); > + else > + val_print_type_code_int (type, valaddr, stream); > + } > break; > > case TYPE_CODE_STRUCT: