From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19835 invoked by alias); 7 May 2002 15:54:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19796 invoked from network); 7 May 2002 15:54:06 -0000 Received: from unknown (HELO maxipes.logix.cz) (217.11.251.37) by sources.redhat.com with SMTP; 7 May 2002 15:54:06 -0000 Received: (qmail 4260 invoked from network); 7 May 2002 15:54:05 -0000 Received: from styx.suse.cz (HELO suse.cz) (hajzl@213.210.157.162) by broucek.logix.cz with SMTP; 7 May 2002 15:54:05 -0000 Message-ID: <3CD7F89C.7050407@suse.cz> Date: Tue, 07 May 2002 08:54:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0rc1) Gecko/20020417 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: Re: [RFC] Re: Proposed fix to gdb for printing 64-bit addresses References: <3CCD8E01.2020500@model.com> <3CD7D446.5020800@suse.cz> <20020507145558.GB17670@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00156.txt.bz2 Daniel Jacobowitz wrote: > On Tue, May 07, 2002 at 03:19:02PM +0200, Michal Ludvig wrote: >>I propose to change the format string from "016l" to just "l" so that >>only valid digits will be printed: >>#0 0x4000d3 in cpyptrs () at dwarf.c:11 >>#1 0x4000f8 in func () at dwarf.c:19 > > I'd rather not do that, actually; I find it very confusing when a > seven-digit hex number is printed (I assume it is an eight-digit one). > It might be appropriate to print just eight digits of low 64-bit > addresses... I don't feel too strongly about this issue, though. So what about changing 'strcpy(addstr, local_hex_string_custom((unsigned long) address, "016l"))' to 'sprintf(addstr, "%010p", address)' ? This would print _at_least_ 8 digits, but wouldn't cut it down when the number is longer. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz