From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16110 invoked by alias); 3 May 2002 17:40:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16102 invoked from network); 3 May 2002 17:40:41 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 3 May 2002 17:40:41 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id KAA12148; Fri, 3 May 2002 10:40:33 -0700 (PDT) Message-ID: <3CD2C897.44AA5ADE@redhat.com> Date: Fri, 03 May 2002 10:40:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sources.redhat.com Subject: Re: Resend: [RFC] p-exp.y enhancements. References: <4.2.0.58.20020502144659.02489e38@ics.u-strasbg.fr> <4.2.0.58.20020503093143.018d5a00@ics.u-strasbg.fr> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2002-05/txt/msg00068.txt.bz2 Pierre Muller wrote: > > At 19:53 02/05/2002 , Michael Snyder a écrit: > >Pierre Muller wrote: > > > > > > (Second posting with the patch attached, > > > this way you should have less problems to > > > apply the patch). > > > > > > This patch has several benefits: > > > > > > 1) it adds support for S[exp] if S is a pascal string. > > > I must admit that this only works for Free Pascal Compiler > > > for now, because GPC uses BITSTRING type > > > for the array containg the chars which confuses GDB. > > > I informed the GPC developper team, but their answer > > > seems to be that they didn't really directly change any code > > > regarding debug information output for pascal... > > > >What will happen if a GPC user tries to do that? > > Well, before it gave an error that there is no [] operator, > after it will give a different error. > ( > > > > 2) it adds support for case insensitive searches of record > > > (pascal struct) fields. > > > >This seems like a good thing... > > > > > > > 3) It prepares to a more simple RFC > > > about the enhancement to the completer for > > > structure field that I sent some time ago. See > > > http://sources.redhat.com/ml/gdb-patches/2002-04/msg00774.html > > > >This seems like a good thing too, but is pretty > >unrelated to the two above. Would you mind breaking > >this patch down into functional units? Since I'm a > >little rusty in both Pascal and Yacc, that will make > >it considerably easier to review. > > No, it is clearly related because, in order to get > a way to get the completer to work of struct fields, > we need of course to know the current_type > of a part of an expression, which is the core of this patch! Sorry Pierre -- I was half asleep when I wrote this. You don't need my approval for these patches anyway. ;-)