From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14995-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 13997 invoked by alias); 2 May 2002 18:06:56 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 13989 invoked from network); 2 May 2002 18:06:54 -0000
Received: from unknown (HELO cygnus.com) (205.180.83.203)
  by sources.redhat.com with SMTP; 2 May 2002 18:06:54 -0000
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA14830;
	Thu, 2 May 2002 11:06:50 -0700 (PDT)
Message-ID: <3CD17D44.DCCC8AD@redhat.com>
Date: Thu, 02 May 2002 11:06:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Pierre Muller <muller@cerbere.u-strasbg.fr>
CC: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Support TYPE_CODE_(BIT)STRING in pascal_type_print_base
References: <4.2.0.58.20020502132416.013c0b30@ics.u-strasbg.fr>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-05/txt/msg00043.txt.bz2

Pierre Muller wrote:
> 
> This patch is here mainly to avoid getting error
> reports for GPC string types.

This seems completely reasonable.  Approved.

> 
> 2002-05-02  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * p-typeprint.c (pascal_type_print_base): Add support
>         for TYPE_CODE_STRING and TYPE_CODE_BITSTRING.
> 
> Index: p-typeprint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/p-typeprint.c,v
> retrieving revision 1.8
> diff -u -p -r1.8 p-typeprint.c
> --- p-typeprint.c       20 Jan 2002 19:42:04 -0000      1.8
> +++ p-typeprint.c       2 May 2002 11:28:23 -0000
> @@ -788,6 +788,14 @@ pascal_type_print_base (struct type *typ
>                           show - 1, level);
>         break;
> 
> +    case TYPE_CODE_BITSTRING:
> +      fputs_filtered ("BitString", stream);
> +      break;
> +
> +    case TYPE_CODE_STRING:
> +      fputs_filtered ("String", stream);
> +      break;
> +
>       default:
>         /* Handle types not explicitly handled by the other cases,
>            such as fundamental types.  For these, just print whatever
> 
> Pierre Muller
> Institut Charles Sadron
> 6,rue Boussingault
> F 67083 STRASBOURG CEDEX (France)
> mailto:muller@ics.u-strasbg.fr
> Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99