From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14922-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 20278 invoked by alias); 29 Apr 2002 23:56:10 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 20271 invoked from network); 29 Apr 2002 23:56:08 -0000
Received: from unknown (HELO cygnus.com) (205.180.83.203)
  by sources.redhat.com with SMTP; 29 Apr 2002 23:56:08 -0000
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA26253;
	Mon, 29 Apr 2002 16:56:04 -0700 (PDT)
Message-ID: <3CCDDAAA.96039FF6@redhat.com>
Date: Mon, 29 Apr 2002 16:56:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Ben Elliston <bje@redhat.com>
CC: gdb-patches@sources.redhat.com, Graydon Hoare <graydon@redhat.com>
Subject: Re: [RFA] patch to testsuite/config/sid.exp
References: <15565.50894.249002.589173@tooth.toronto.redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-04/txt/msg01143.txt.bz2

Ben Elliston wrote:
> 
> The following patch (submitted on behalf of Graydon Hoare) adds
> support for testing GDB on SID simulators using a new mode of
> invocation.  Okay to commit?
> 
> Ben

It all looks ok to me, except I have a question about...

> 
> 2002-02-14  Graydon Hoare  <graydon@redhat.com>
> 
>         * config/sid.exp: Include support for "rawsid" protocol.
> 
> Index: config/sid.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/config/sid.exp,v
> retrieving revision 1.25
> diff -u -p -r1.25 sid.exp
> --- sid.exp     2002/04/05 23:31:59     1.25
> +++ sid.exp     2002/04/29 22:16:49
> @@ -53,6 +53,8 @@ proc sid_start {} {
>         }
>         if { [board_info target sim,protocol] == "sid" } {
>             set spawncmd "[target_info sim] [target_info sim,options] $sidendian2 -e \"set cpu-gdb-socket sockaddr-local 0.0.0.0:$port\""
> +       } elseif { [board_info target sim,protocol] == "rawsid" } {
> +           set spawncmd "[target_info sim] [target_info sim,options] -$sidendian --gdb=$port"
>         } else {
>             set spawncmd "../../sid/bsp/[target_info sim] $sidendian --gdb=$port [target_info sim,options]"

one of the diffs between these two spawncmds, namely, that the old one
specifies a path before [target_info sim], but your new one doesn't.

Is that intentional?

>         }
> @@ -67,6 +69,8 @@ proc sid_start {} {
>             # FIXME: sim,options may be from the build tree, should find
>             # it in the install tree.
>             set spawncmd "sid [target_info sim,options] $sidendian2 -e \"set cpu-gdb-socket sockaddr-local 0.0.0.0:$port\""
> +       } elseif { [board_info target sim,protocol] == "rawsid" } {
> +           set spawncmd "[target_info sim] [target_info sim,options] -$sidendian --gdb=$port"
>         } else {
>             set spawncmd "[target_info sim] $sidendian --gdb=$port [target_info sim,options]"
>         }