From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17148 invoked by alias); 29 Apr 2002 17:11:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17139 invoked from network); 29 Apr 2002 17:11:14 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 29 Apr 2002 17:11:14 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 086F659D348; Mon, 29 Apr 2002 19:11:13 +0200 (CEST) Received: from suse.cz (leviathan.suse.cz [10.20.1.56]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g3THBCf06375; Mon, 29 Apr 2002 19:11:12 +0200 X-Authentication-Warning: chimera.suse.cz: Host leviathan.suse.cz [10.20.1.56] claimed to be suse.cz Message-ID: <3CCD7EA6.4020807@suse.cz> Date: Mon, 29 Apr 2002 10:11:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0rc1) Gecko/20020417 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Pierre Muller Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [RFA] New bitflags type and eflags on i386/x86-64 References: <3CC42916.9080001@suse.cz> <3CC42916.9080001@suse.cz> <4.2.0.58.20020429180717.020bacb0@ics.u-strasbg.fr> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg01125.txt.bz2 Pierre Muller wrote: > Given this info, I would support the creation of a TYPE_CODE_FLAGS > rather than trying to use pascal sets. > Note that the code submitted does failm to write the flags if language is set to > pascal for instance... So this means that the p-valprint and > maybe others (f-valprint or jv-valprint code should be adapted too). > So maybe the best would be to move thiscode from c-valprint.c to valprint.c > and simply call it for the different language-valprint.c sources. Thanks for comments. I'll rework the patch and send again for approval with these changes. I was never a fan of "raping" type SET for this purpose. > Last but not least, adding this patch for i386-tdep source would allow to use > this code also for normal i386 cpus. Sure, this bit is easy. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz