From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24872 invoked by alias); 26 Apr 2002 13:32:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24849 invoked from network); 26 Apr 2002 13:32:39 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 26 Apr 2002 13:32:39 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 798FE3D5A; Fri, 26 Apr 2002 09:32:38 -0400 (EDT) Message-ID: <3CC956F6.5000100@cygnus.com> Date: Fri, 26 Apr 2002 06:32:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020424 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pierre Muller Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA 2nd] hpread.c printf (stderr,... ->fprintf_unfiltered (gdb_stderr,.. References: <4.2.0.58.20020426105725.0233c338@ics.u-strasbg.fr> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg01081.txt.bz2 > in hpread.c > there is a line with > #include "syms.h" > but there is no syms.h > in the gdb sources... > > If I do a 'grep -n syms.h *.c in gdb directory, > I get only this: > $ grep -n syms.h *.c > hpread.c:29:#include "syms.h" > somread.c:25:#include > > Is the hpread.c file obsolete? > Or shouldn't it be also > #include > like in somread.c? I need to tread carefuly here, skating on thin ice :-) There is the strict ISO C defined behavour of "" vs <> and then there are accepted conventions (note plural). Within GDB, the accepted convention is to use <> as as "syms.h" is a system header. In theory, it should be possible for you to compile hpread.c on any system, because of includes like the above, it isn't (hence the MAINTAINERS file marks it as broken). Consequently, yes, ok. Andrew