Re: which patches to review

Kevin Buettner
2002-04-24T19:16:53Z

On Apr 24, 10:38am, David S. Miller wrote:

> Right now all of the Sparc Linux bits are in a pending state because
> they need to be sequenced after the multi-arch bits. Currently, this
> one is holding up sparc-linux-tdep from being added:
>
> http://sources.redhat.com/ml/gdb-patches/2002-04/msg00710.html

I just took a quick look at this one and I think it's okay. I was
going to complain about the fact this...

+#if (GDB_TARGET_IS_SPARC64)
+#define FP_MAX_REGNUM (FP0_REGNUM + 48)
+#else
+#define FP_MAX_REGNUM (FP0_REGNUM + 32)
+#endif

...appears in the new sparc-tdep.h, but then I realized that this was
simply moved over verbatim from sparc-tdep.c. It seems reasonable to
me that this could/should be cleaned up in a later patch.

Anyway, I recommend that David's lynch-pin patch be approved.

Kevin