Re: [RFA] Improve Sparc epilogue analysis

Michael Snyder
2002-04-25T00:48:21Z

"David S. Miller" wrote:
>
> From: Michael Snyder <msnyder@redhat.com>
> Date: Wed, 24 Apr 2002 16:14:56 -0700
>
> In this case, I don't believe you got the frameless_p case
> right. First, you don't seem to have changed the definition
> of SKIP_PROLOGUE_FRAMELESS_P in tm-sparc.h. Second, your
> implementation of sparc_prologue_frameless_p is not
> functionally equivalent to the old one. If it goes thru
> the new, symbolic path, it will not return the same result.
>
> SKIP_PROLOGUE_FRAMELESS_P died within the past day or two from the
> whole GDB tree, perhaps you didn't notice :-)

No I didn't. I don't read every message on this list.

>
> I'd like to ask that you re-review this change, given this, please.

The part that's mentioned in the changelog entry is OK, except
you can remove sparc_skip_prologue_frameless_p (and say so in
the changelog) rather than rewrite it.

The parts that are NOT mentioned in the changelog (your changes
to the logic in sparc_init_extra_frame_info) are not OK, first
because you didn't mention them in the changelog, and second
because I can't convince myself that they are right.

I'd like you to resubmit this patch with those modifications, please.

Michael