Re: [RFA] Improve Sparc epilogue analysis

David S. Miller
2002-04-26T01:38:37Z

From: Michael Snyder <msnyder@redhat.com>
Date: Thu, 25 Apr 2002 14:04:21 -0700

> I know you're going to explode at me,

Why would you say that? Have I exploded at you up till now?

Yes you did. You did it when I commented on the errors in your
reviewing of patches last time. You said that you wouldn't have
reviewed any of my patches that day had you read the email in
question before doing so. That, to me, is "blowing up".

> but you seem to make a lot of errors reviewing my changes.

If so, I would like to know about it. Please detail
one of my errors for the group.

The first patch of mine you reviewed you asked "is this a sparc
specific issue", when if you had really read the patch in it's
entirety, for the change in question, I added a long winded comment
that said that this was a sparc specific issue.

That was an error in patch review, and it showed to me that you
had only skimmed over my patch quickly instead of really having
a good look at it.

Your change to sparc_init_extra_frame_info changes its logic
and its black-box behavior. You have said nothing about why
you made this change. It's not my job to guess why you did it,
it's my job to reject your change until you explain it.

You said I did not make any reference at all to the change
in my changelog entries, that is how you phrased it and that
is what I took issue with.

If you had told me to discuss the change "in more detail" that
would have been different.

It's also not my job to take shit from you.

And it's not my job to take it from you either.