Re: [RFA] Improve Sparc epilogue analysis

Michael Snyder
2002-04-25T21:16:37Z

"David S. Miller" wrote:
>
> From: Michael Snyder <msnyder@redhat.com>
> Date: Wed, 24 Apr 2002 17:36:02 -0700
>
> The parts that are NOT mentioned in the changelog (your changes
> to the logic in sparc_init_extra_frame_info) are not OK, first
> because you didn't mention them in the changelog, and second
> because I can't convince myself that they are right.
>
> Michael, I hate keeping on about this, but I did mention
> them in my changes:
>
> (sparc_init_extra_frame_info): Use sparc_skip_prologue to find
> prologue bounds instead of looking at line number info by hand.

That entry says nothing about changing the logic or the functional
behavior.

> I know you're going to explode at me,

Why would you say that? Have I exploded at you up till now?

> but you seem to make a lot of errors reviewing my changes.

If so, I would like to know about it. Please detail
one of my errors for the group.

> Please settle down, take your time.

I'm going to remind you of this comment the next time you
rail about my not reviewing one of your changes on a Saturday.

> At
> this point I'd much rather you delay than review things haphazardly.

And I'd much rather you consider my reviews seriously, rather
than assume they are haphazard or erroneous. I have been doing
this for a while, you know...

Your change to sparc_init_extra_frame_info changes its logic
and its black-box behavior. You have said nothing about why
you made this change. It's not my job to guess why you did it,
it's my job to reject your change until you explain it.

It's also not my job to take shit from you. Change your attitude,
David. Change it now.