From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32278 invoked by alias); 25 Apr 2002 00:06:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32265 invoked from network); 25 Apr 2002 00:06:42 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by 209.249.29.67 with SMTP; 25 Apr 2002 00:06:42 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 80B8A3D29; Wed, 24 Apr 2002 20:06:31 -0400 (EDT) Message-ID: <3CC74887.2070401@cygnus.com> Date: Wed, 24 Apr 2002 17:06:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020424 X-Accept-Language: en-us, en MIME-Version: 1.0 To: thorpej@wasabisystems.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Use multi-arch'd START_INFERIOR_TRAPS_EXPECTED on Alpha target References: <20020421181544.S1627@dr-evil.shagadelic.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00986.txt.bz2 > The following puts STARTUP_WITH_SHELL Hmm, HP merge. An intermediate version looked like: /* If STARTUP_WITH_SHELL is set, GDB's "run" ! * will attempts to start up the debugee under a shell. ! * This is in order for argument-expansion to occur. E.g., ! * (gdb) run * ! * The "*" gets expanded by the shell into a list of files. ! * While this is a nice feature, it turns out to interact badly ! * with some of the catch-fork/catch-exec features we have added. ! * In particular, if the shell does any fork/exec's before ! * the exec of the target program, that can confuse GDB. ! * To disable this feature, set STARTUP_WITH_SHELL to 0. ! * To enable this feature, set STARTUP_WITH_SHELL to 1. ! * The catch-exec traps expected during start-up will ! * be 1 if target is not started up with a shell, 2 if it is. ! * - RT ! */ #define STARTUP_WITH_SHELL 1 - #define START_INFERIOR_TRAPS_EXPECTED (STARTUP_WITH_SHELL + 1) Does STARTUP_WITH_SHELL need to be multi-arched? I'm wondering if it would be better to make it a variable (``set startup-with-shell ''). Looking at its uses it appears that fork-child.c:startup_inferior() would still work (if it did previously). Andrew