From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3615 invoked by alias); 24 Apr 2002 19:08:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3608 invoked from network); 24 Apr 2002 19:08:33 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 24 Apr 2002 19:08:33 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA21978; Wed, 24 Apr 2002 12:01:57 -0700 (PDT) Message-ID: <3CC6FE52.F517979E@redhat.com> Date: Wed, 24 Apr 2002 12:08:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered(gdb_stderr,... in hpread.c References: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00966.txt.bz2 Pierre Muller wrote: > > This is a second of the files that I listed in > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html > as still having direct uses of stderr. > > I did not fix a 80 char overflow, because I didn't find a good way to do it: > If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" > with gdb_stderr, I still get an overflow, how show I indent the args then? > Should I break the string constant? I've spent more time agonizing over such questions than I care to admit. ;-) And I'm fairly strongly opinionated against greater-than-80-char lines. But I think when it comes to printf and string constants, we have to be a little loose about it. If you wanted to do something really perverted, you could try this: fprintf_unfiltered (gdb_stderr, "Psymtab for %s %s %s\n", pst->filename, "already read in. ", "Shouldn't happen."); > > ChangeLog entry: > > 2002-04-24 Pierre Muller > * hpread.c (hpread_psymtab_to_symtab_1, > hpread_psymtab_to_symtab): Replace fprintf (stderr,... > with fprintf_unfiltered (gdb_stderr,.... > > Index: hpread.c > =================================================================== > RCS file: /cvs/src/src/gdb/hpread.c,v > retrieving revision 1.15 > diff -u -p -r1.15 hpread.c > --- hpread.c 15 Apr 2002 04:52:08 -0000 1.15 > +++ hpread.c 24 Apr 2002 12:41:18 -0000 > @@ -2693,7 +2693,7 @@ hpread_psymtab_to_symtab_1 (struct parti > /* Complain if we've already read in this symbol table. */ > if (pst->readin) > { > - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", > + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. Shouldn't happen.\n", > pst->filename); > return; > } > @@ -2748,7 +2748,7 @@ hpread_psymtab_to_symtab (struct partial > /* Sanity check. */ > if (pst->readin) > { > - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", > + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. Shouldn't happen.\n", > pst->filename); > return; > }