Re: [RFA] New bitflags type and eflags on i386/x86-64

Pierre Muller
2002-08-30T14:09:50Z

At 15:52 30/08/2002 , vous avez Ã©crit:
>Andrew Cagney wrote:
>>Is there any immediate technical problem stopping x86-64 linking in i386-tdep.c? (Yes scary, multi-arch).
>
>Yes, if both are linked, the gdbarch initialisation is attempted to be done twice and gdb crashes. I could add an #ifdef to optionally ignore some parts of i386-tdep, but IMHO it's better to introduce a new file as DanielJ proposed. See the patch. I've moved both new builtin types and their initialisation to i386-common-tdep.c and modified all config/i386/*.mt files to require it. This approach shouldn't harm MarkK's effort at all.
>Any objections or can I commit it?

This looks quite good in general,
but I don't have the time to test the patch myself...

I was just afraid of one thing :

will it still be possible to do arithmetics
on those registers ?

say that you want to clear on flag
in the $eflags registers

before your patch you could do

set $eflags &=0xfffe
if you wanted to clear the flag at position zero.
Will this still be possible without typecasting the flag register ?
or willsomething like
set $eflags = $eflags | [ZF]
be possible ?

Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99