Re: [RFA] Sparc/Linux fixes part 1

[Andrew Cagney <ac131313@cygnus.com>]

>  From: Jason R Thorpe <thorpej@wasabisystems.com>
> Date: Sat, 20 Apr 2002 21:24:25 -0700
> 
>    On Sat, Apr 20, 2002 at 08:09:57PM -0700, David S. Miller wrote:
>    
>     > I produced a backlog of 12 patches, then Jason Thorpe posted his
>     > patch.  You choose to review his change before any of the rest of
>     > mine.
>    
>    Err, I don't think you're being completely fair to Andrew, here.  The
>    patch I posted to frame.c today was quite trivial, and the code it fixed
>    was pretty obviously broken, and thus the patch very easy to review.
> 
> I posted patches of similar complexity.  For example:
> 
> 	http://sources.redhat.com/ml/gdb-patches/2002-04/msg00675.html
> 

The number of lines in a patch is not a good indicator of the amount of 
time required or the relative priority of a submitted change.

The other patch didn't contain a single macro, it refered to one 
one-line function (which I know backwards), it fixes a core dump, and 
the patch itself contained all the relevant code in question.  Given I 
only just changed the code myself, I'm also ``on the hook'' for any fallout.

On the other hand, the above patch contains alloca, macros, and zero 
context (surounding code).  It is changing code that currently works 
(just not efficiently) and, if wrong, will cause a stack buffer overrun.

enjoy,Andrew