From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14289-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 27421 invoked by alias); 14 Apr 2002 22:22:13 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 27413 invoked from network); 14 Apr 2002 22:22:11 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.240.27)
  by sources.redhat.com with SMTP; 14 Apr 2002 22:22:11 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id B54683C3F; Sun, 14 Apr 2002 18:22:13 -0400 (EDT)
Message-ID: <3CBA0115.70009@cygnus.com>
Date: Sun, 14 Apr 2002 15:22:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Snyder <msnyder@redhat.com>,
	Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Save SSE registers to generated core files, without breaking
  other architectures
References: <20020402145546.A7582@nevyn.them.org> <3CAA274A.C0170CF@redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-04/txt/msg00510.txt.bz2

> Daniel Jacobowitz wrote:
> 
>> 
>> How does this patch look?  The original problem was that we can not rely on
>> HAVE_PTRACE_FPXREGSET, because the presence of PTRACE_FPXREGSET doesn't
>> imply that GDB has a fill_fpxregset function available.  I updated it to
>> check for a separate flag.  It's not ideal, but until we separate regset
>> handling into an appropriate vector, it's the best we can do (I think).
>> 
>> OK?
> 
> 
> Well, I like it (and thanks for working on it), 
> but Andrew might have something to say about adding
> a new macro.   Andrew?


>> * config/i386/tm-linux.h: Define FILL_FPXREGSET.

linux-proc.c is only built native so I think FILL_.. should only be 
defined for native builds => config/i386/nm-linux.h.

Having #ifdef code enabled via a tm.h file macro just feels wrong.

enjoy,
Andrew