Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Per Bothner <per@bothner.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATH: reset innermost_block on 'run'
Date: Thu, 11 Apr 2002 17:49:00 -0000	[thread overview]
Message-ID: <3CB62C4C.A58FDBE2@redhat.com> (raw)
In-Reply-To: <3CB62486.1030104@bothner.com>

Per Bothner wrote:
> 
> It's been a while since I made this change, but as I recall
> without it gdb will tend to crash when you re-start the
> inferior using a 'run' command.
> 
> Now I don't know exactly the best place to reset the
> innermost_block variable, but it *is* a cache variable
> that must be reset whenever execution continues, including
> on each 'run'.

Eeeewww!  I believe you're right!   ;-(
Thanks for the catch, but I don't believe run_command is the right spot.
If we want to do it whenever execution resumes, then how about putting
it
in resume()?



> 
>         * infcmd.c (run_command):  Reset innermost_block.
> --
>         --Per Bothner
> per@bothner.com   http://www.bothner.com/per/
> 
>   ------------------------------------------------------------------------
> Index: infcmd.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/infcmd.c,v
> retrieving revision 1.43
> diff -u -p -r1.43 infcmd.c
> --- infcmd.c    28 Mar 2002 01:35:55 -0000      1.43
> +++ infcmd.c    11 Apr 2002 23:57:47 -0000
> @@ -387,6 +387,8 @@ Start it from the beginning? "))
>        init_wait_for_inferior ();
>      }
> 
> +  innermost_block = NULL;
> +
>    clear_breakpoint_hit_counts ();
> 
>    /* Purge old solib objfiles. */


  reply	other threads:[~2002-04-12  0:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-11 17:04 Per Bothner
2002-04-11 17:49 ` Michael Snyder [this message]
2002-04-11 17:54   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CB62C4C.A58FDBE2@redhat.com \
    --to=msnyder@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=per@bothner.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox