From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3137 invoked by alias); 9 Apr 2002 03:05:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3079 invoked from network); 9 Apr 2002 03:05:22 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 9 Apr 2002 03:05:22 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5001F3EF8; Mon, 8 Apr 2002 23:05:24 -0400 (EDT) Message-ID: <3CB25A74.1080308@cygnus.com> Date: Mon, 08 Apr 2002 20:05:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nick Clifton Cc: Anthony Green , gdb-patches@sources.redhat.com Subject: Re: [rfa] Add -m; Was: ARM sim patch: increase default target memory References: <200203171650.g2HGo8714138@louie.sfbay.redhat.com> <3CB07C82.3040902@cygnus.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00343.txt.bz2 > Hi Andrew, > > >> The attatched patch (er, hack), adds support for the -m flag from >> the GDB command line (vis (gdb) target sim -m). > > > Hmm, this looks generally OK to me, except that I would recommend > using "strtoul" instead of "atoi" to convert the string into a > number, so that hex values can be specified as well as decimal. Good point. > I > would also suggest that you consider adding support for a megabyte > postfix so that the user could do: > > -m 6M Good idea, all the sims should do this. Any pointers for the code? I'll likely bug report it for now. > to set up a 6 megabyte virtual memory, instead of having to type: > > -m 6291456 > > >> It also sets the default memory size back to something consistent >> with the other simulators. > > > This will stop the java tests from running, so maybe you should also > add the new switch to the java test harness so that they do not fail. Do you know which file? Andrew