From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11108 invoked by alias); 5 Apr 2002 22:30:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11100 invoked from network); 5 Apr 2002 22:30:22 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 5 Apr 2002 22:30:22 -0000 Received: from redhat.com (rtl.cygnus.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA02781; Fri, 5 Apr 2002 14:29:57 -0800 (PST) Message-ID: <3CAE24CB.CF4D966F@redhat.com> Date: Fri, 05 Apr 2002 14:30:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Accept-Language: en MIME-Version: 1.0 To: Elena Zannoni CC: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] Multilibs and gdb.asm References: <15534.5336.562102.896601@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00190.txt.bz2 This is very unfortunate, but if there is no way around it we have no other choice. Go ahead, please. Fernando Elena Zannoni wrote: > > In gdb.asm/asm-source.exp, the testsuite passes multilib options to > the assembler according to the compiler syntax. > Obviously this doesn't work, as already noted by Nick Clifton in: > > http://sources.redhat.com/ml/gdb-patches/2002-01/msg00282.html > > A solution wasn't reached at the time. > > I found it useful to just bail out of the test if some multilibs were > detected. At least it reduced the noise in the testsuite results. > > Is this too drastic? > > Elena > > 2002-04-05 Elena Zannoni > > * gdb.asm/asm-source.exp: Bail out if multilibs are detected. > > Index: asm-source.exp > =================================================================== > RCS file: /cvs/uberbaum/gdb/testsuite/gdb.asm/asm-source.exp,v > retrieving revision 1.19 > diff -u -p -r1.19 asm-source.exp > --- asm-source.exp 2002/04/05 02:48:23 1.19 > +++ asm-source.exp 2002/04/05 21:15:04 > @@ -67,10 +67,29 @@ if { "${asm-arch}" == "" } { > gdb_suppress_entire_file "Assembly source test -- not implemented for this target." > } > > +# Watch out, we are invoking the assembler, but the testsuite sets multilib > +# switches according to compiler syntax. If we pass these options straight > +# to the assembler, they won't always make sense. If we don't pass them to > +# the assembler, the final link will complain that the object files were > +# built with different defaults. So no matter what we do, we lose. We may as > +# well get out of this test sooner rather than later. > +set dest [target_info name] > +if [board_info $dest exists multilib_flags] { > + set multilib_flags [board_info $dest multilib_flags] > + if { "${multilib_flags}" != "" } { > + gdb_suppress_entire_file "Assembly source test -- multilibs not supported by this test." > + return; > + } > +} > + > set testfile "asm-source" -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9