From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13914-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 18601 invoked by alias); 4 Apr 2002 22:03:49 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18591 invoked from network); 4 Apr 2002 22:03:44 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 4 Apr 2002 22:03:44 -0000
Received: from redhat.com (notinuse.cygnus.com [205.180.231.12])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA04549;
	Thu, 4 Apr 2002 14:03:42 -0800 (PST)
Message-ID: <3CACCB12.649802F8@redhat.com>
Date: Thu, 04 Apr 2002 14:03:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Cagney <ac131313@cygnus.com>
CC: Michael Snyder <msnyder@cygnus.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add overlay event support to testcase.
References: <200204041937.g34JbPT11046@reddwarf.cygnus.com> <3CACB764.2010409@cygnus.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-04/txt/msg00135.txt.bz2

Andrew Cagney wrote:
> 
> > 2002-04-04  Michael Snyder  <msnyder@redhat.com>
> >
> > * gdb.base/ovlymgr.c: Add overlay event breakpoint support.
> 
> Will adding this mean that the event-breakpoint mechanism is the only
> one tested?

Hmmm, good question.  I guess it will.
Should I clone the test case so we test both?


> 
> Andrew
> 
> > Index: gdb.base/ovlymgr.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ovlymgr.c,v
> > retrieving revision 1.2
> > diff -c -3 -p -r1.2 ovlymgr.c
> > *** ovlymgr.c 2002/02/05 03:44:25     1.2
> > --- ovlymgr.c 2002/04/04 19:47:38
> > *************** FlushCache (void)
> > *** 30,35 ****
> > --- 30,44 ----
> >   #endif
> >   }
> >
> > + /* _ovly_debug_event:
> > +  * Debuggers may set a breakpoint here, to be notified
> > +  * when the overlay table has been modified.
> > +  */
> > + static void
> > + _ovly_debug_event (void)
> > + {
> > + }
> > +
> >   /* OverlayLoad:
> >    * Copy the overlay into its runtime region,
> >    * and mark the overlay as "mapped".
> > *************** OverlayLoad (unsigned long ovlyno)
> > *** 57,63 ****
> >            _ovly_table[ovlyno][SIZE]);
> >
> >     FlushCache ();
> > !
> >     return TRUE;
> >   }
> >
> > --- 66,72 ----
> >            _ovly_table[ovlyno][SIZE]);
> >
> >     FlushCache ();
> > !   _ovly_debug_event ();
> >     return TRUE;
> >   }
> >
> > *************** OverlayUnload (unsigned long ovlyno)
> > *** 80,85 ****
> > --- 89,95 ----
> >            _ovly_table[ovlyno][VMA],
> >            _ovly_table[ovlyno][SIZE]);
> >
> > +   _ovly_debug_event ();
> >     return TRUE;
> >   }
> >
> >