From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13903-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 29428 invoked by alias); 4 Apr 2002 20:28:20 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 29419 invoked from network); 4 Apr 2002 20:28:19 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 4 Apr 2002 20:28:19 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id E13003E78; Thu,  4 Apr 2002 15:28:20 -0500 (EST)
Message-ID: <3CACB764.2010409@cygnus.com>
Date: Thu, 04 Apr 2002 12:28:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Snyder <msnyder@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add overlay event support to testcase.
References: <200204041937.g34JbPT11046@reddwarf.cygnus.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-04/txt/msg00124.txt.bz2

> 2002-04-04  Michael Snyder  <msnyder@redhat.com>
> 
> * gdb.base/ovlymgr.c: Add overlay event breakpoint support.

Will adding this mean that the event-breakpoint mechanism is the only 
one tested?

Andrew


> Index: gdb.base/ovlymgr.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ovlymgr.c,v
> retrieving revision 1.2
> diff -c -3 -p -r1.2 ovlymgr.c
> *** ovlymgr.c	2002/02/05 03:44:25	1.2
> --- ovlymgr.c	2002/04/04 19:47:38
> *************** FlushCache (void)
> *** 30,35 ****
> --- 30,44 ----
>   #endif
>   }
>   
> + /* _ovly_debug_event:
> +  * Debuggers may set a breakpoint here, to be notified 
> +  * when the overlay table has been modified.
> +  */
> + static void
> + _ovly_debug_event (void)
> + {
> + }
> + 
>   /* OverlayLoad:
>    * Copy the overlay into its runtime region,
>    * and mark the overlay as "mapped".
> *************** OverlayLoad (unsigned long ovlyno)
> *** 57,63 ****
>   	     _ovly_table[ovlyno][SIZE]);
>   
>     FlushCache ();
> ! 
>     return TRUE;
>   }
>   
> --- 66,72 ----
>   	     _ovly_table[ovlyno][SIZE]);
>   
>     FlushCache ();
> !   _ovly_debug_event ();
>     return TRUE;
>   }
>   
> *************** OverlayUnload (unsigned long ovlyno)
> *** 80,85 ****
> --- 89,95 ----
>   	     _ovly_table[ovlyno][VMA],
>   	     _ovly_table[ovlyno][SIZE]);
>   
> +   _ovly_debug_event ();
>     return TRUE;
>   }
>   
>