From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27900 invoked by alias); 4 Apr 2002 03:27:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27870 invoked from network); 4 Apr 2002 03:27:28 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 4 Apr 2002 03:27:28 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DEFEF3E5A; Wed, 3 Apr 2002 22:27:24 -0500 (EST) Message-ID: <3CABC81C.9000100@cygnus.com> Date: Wed, 03 Apr 2002 19:27:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: Minor off-by-one error in command_line_handler References: <20020327000106.A24311@molenda.com> <20020329025400.A25885@nevyn.them.org> <3CA4A5E5.7060904@cygnus.com> <20020331000843.A17713@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00092.txt.bz2 > Does > /* We're careful not to read beyond the last BLOCK_SYM. */ > look about right to you? Yes, or: ``The hoops are to avoid ... '' :-) Andrew > On Fri, Mar 29, 2002 at 12:35:33PM -0500, Andrew Cagney wrote: > >> It at least deserves a comment :-) >> > >> > #define ALL_BLOCK_SYMBOLS(bl, i, sym) \ >> > for ((i) = 0, (sym) = BLOCK_SYM ((bl), (i)); \ >> > (i) < BLOCK_NSYMS ((bl)); \ >> >- ++(i), (sym) = BLOCK_SYM ((bl), (i))) >> >+ ++(i), (sym) = ((i) < BLOCK_NSYMS ((bl))) \ >> >+ ? BLOCK_SYM ((bl), (i)) \ >> >+ : NULL) >> > > >> >> Andrew >> >> > >